qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Bligh <alex@alex.org.uk>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, Alexandre Derumier <aderumier@odiso.com>,
	Alex Bligh <alex@alex.org.uk>
Subject: Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)
Date: Thu, 22 Aug 2013 20:46:08 +0100	[thread overview]
Message-ID: <628ABA3A75FF6CD5BF8573E8@nimrod.local> (raw)
In-Reply-To: <521666E1.2020902@redhat.com>



--On 22 August 2013 21:30:41 +0200 Paolo Bonzini <pbonzini@redhat.com> 
wrote:

>>> Also, this is the same as some HMP commands' "-n" option (live
>>> snapshots, mirroring, backup) so I suggest to use that name.
>>
>> You mean -n instead of -C? Sure I can do that, but is that
>> something you feel strongly about? I am aware there are a number
>> of people who have been using the patch with -C for some time.
>
> I'll be fine if Stefan and Kevin override me, but yes, I think
> consistency is important.  qemu-img has offline functionality equivalent
> to block jobs, and it is useful to keep qemu-img subcommands as
> consistent as possible between them and with the corresponding HMP
> commands.  convert is the equivalent of the online mirroring block job.

I note -f in hmp means 'whole disk' whereas in qemu-img it means 'format'.
A quick scan suggests there are no other flags that do similar things.
So this would be the first flag that is consistent I think!

-- 
Alex Bligh

  reply	other threads:[~2013-08-22 19:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 11:41 [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation) Alex Bligh
2013-08-22 11:45 ` Stefan Hajnoczi
2013-08-22 12:35   ` Paolo Bonzini
2013-08-22 18:03     ` Alex Bligh
2013-08-22 19:30       ` Paolo Bonzini
2013-08-22 19:46         ` Alex Bligh [this message]
2013-08-22 19:41       ` Eric Blake
2013-08-26  8:07       ` Stefan Hajnoczi
2013-08-22 19:27   ` Alex Bligh
2013-08-26  8:03     ` Stefan Hajnoczi
2013-08-26  9:13       ` Alex Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=628ABA3A75FF6CD5BF8573E8@nimrod.local \
    --to=alex@alex.org.uk \
    --cc=aderumier@odiso.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).