* [PATCH] machine: Provide a description for aux-ram-share property
@ 2025-11-05 19:11 Peter Xu
2025-11-21 18:29 ` Fabiano Rosas
0 siblings, 1 reply; 5+ messages in thread
From: Peter Xu @ 2025-11-05 19:11 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Fabiano Rosas, Zhao Liu, Yanan Wang, peterx,
Philippe Mathieu-Daudé, Peter Maydell, Marcel Apfelbaum
It was forgotten when being introduced in commit 91792807d1 ("machine:
aux-ram-share option").
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/core/machine.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 0580550e12..8dd8ce4cac 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1200,6 +1200,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
object_class_property_add_bool(oc, "aux-ram-share",
machine_get_aux_ram_share,
machine_set_aux_ram_share);
+ object_class_property_set_description(oc, "aux-ram-share",
+ "Use anonymous shared memory for auxilliary guest RAMs");
#endif
object_class_property_add_bool(oc, "usb",
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] machine: Provide a description for aux-ram-share property
2025-11-05 19:11 Peter Xu
@ 2025-11-21 18:29 ` Fabiano Rosas
0 siblings, 0 replies; 5+ messages in thread
From: Fabiano Rosas @ 2025-11-21 18:29 UTC (permalink / raw)
To: Peter Xu, qemu-devel
Cc: Eduardo Habkost, Zhao Liu, Yanan Wang, peterx,
Philippe Mathieu-Daudé, Peter Maydell, Marcel Apfelbaum
Peter Xu <peterx@redhat.com> writes:
> It was forgotten when being introduced in commit 91792807d1 ("machine:
> aux-ram-share option").
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 0580550e12..8dd8ce4cac 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1200,6 +1200,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
> object_class_property_add_bool(oc, "aux-ram-share",
> machine_get_aux_ram_share,
> machine_set_aux_ram_share);
> + object_class_property_set_description(oc, "aux-ram-share",
> + "Use anonymous shared memory for auxilliary guest RAMs");
s/auxilliary/auxiliary/
> #endif
>
> object_class_property_add_bool(oc, "usb",
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] machine: Provide a description for aux-ram-share property
@ 2025-11-24 19:14 Peter Xu
2025-11-24 21:47 ` Fabiano Rosas
2025-11-25 21:50 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 5+ messages in thread
From: Peter Xu @ 2025-11-24 19:14 UTC (permalink / raw)
To: qemu-devel
Cc: Fabiano Rosas, Eduardo Habkost, Zhao Liu, peterx, Yanan Wang,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Peter Maydell
It was forgotten when being introduced in commit 91792807d1 ("machine:
aux-ram-share option").
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
v2:
- Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
---
hw/core/machine.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 06e0c9a179..27372bb01e 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1204,6 +1204,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
object_class_property_add_bool(oc, "aux-ram-share",
machine_get_aux_ram_share,
machine_set_aux_ram_share);
+ object_class_property_set_description(oc, "aux-ram-share",
+ "Use anonymous shared memory for auxiliary guest RAMs");
#endif
object_class_property_add_bool(oc, "usb",
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] machine: Provide a description for aux-ram-share property
2025-11-24 19:14 [PATCH] machine: Provide a description for aux-ram-share property Peter Xu
@ 2025-11-24 21:47 ` Fabiano Rosas
2025-11-25 21:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 5+ messages in thread
From: Fabiano Rosas @ 2025-11-24 21:47 UTC (permalink / raw)
To: Peter Xu, qemu-devel
Cc: Eduardo Habkost, Zhao Liu, peterx, Yanan Wang, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Peter Maydell
Peter Xu <peterx@redhat.com> writes:
> It was forgotten when being introduced in commit 91792807d1 ("machine:
> aux-ram-share option").
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 06e0c9a179..27372bb01e 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1204,6 +1204,8 @@ static void machine_class_init(ObjectClass *oc, const void *data)
> object_class_property_add_bool(oc, "aux-ram-share",
> machine_get_aux_ram_share,
> machine_set_aux_ram_share);
> + object_class_property_set_description(oc, "aux-ram-share",
> + "Use anonymous shared memory for auxiliary guest RAMs");
> #endif
>
> object_class_property_add_bool(oc, "usb",
Reviewed-by: Fabiano Rosas <farosas@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] machine: Provide a description for aux-ram-share property
2025-11-24 19:14 [PATCH] machine: Provide a description for aux-ram-share property Peter Xu
2025-11-24 21:47 ` Fabiano Rosas
@ 2025-11-25 21:50 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-11-25 21:50 UTC (permalink / raw)
To: Peter Xu, qemu-devel
Cc: Fabiano Rosas, Eduardo Habkost, Zhao Liu, Yanan Wang,
Marcel Apfelbaum, Peter Maydell
On 24/11/25 20:14, Peter Xu wrote:
> It was forgotten when being introduced in commit 91792807d1 ("machine:
> aux-ram-share option").
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> v2:
> - Fix spelling, s/auxilliary/auxiliary/ [Fabiano]
> ---
> hw/core/machine.c | 2 ++
> 1 file changed, 2 insertions(+)
Queued, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-11-25 21:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-24 19:14 [PATCH] machine: Provide a description for aux-ram-share property Peter Xu
2025-11-24 21:47 ` Fabiano Rosas
2025-11-25 21:50 ` Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2025-11-05 19:11 Peter Xu
2025-11-21 18:29 ` Fabiano Rosas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).