From: Thomas Huth <thuth@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v9 02/10] acpi: move aml builder code for floppy device
Date: Wed, 17 Jun 2020 10:40:24 +0200 [thread overview]
Message-ID: <62ad00f7-c7f2-ed80-01a3-8d8c6aa9fba9@redhat.com> (raw)
In-Reply-To: <20200617071138.11159-3-kraxel@redhat.com>
On 17/06/2020 09.11, Gerd Hoffmann wrote:
> DSDT change: isa device order changes in case MI1 (ipmi) is present.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/block/fdc.c | 83 ++++++++++++++++++++++++++++++++
> hw/i386/acpi-build.c | 83 --------------------------------
> stubs/cmos.c | 7 +++
> stubs/Makefile.objs | 1 +
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 5086 -> 5086 bytes
> 5 files changed, 91 insertions(+), 83 deletions(-)
> create mode 100644 stubs/cmos.c
Hmm, not all targets that use CONFIG_FDC also have ACPI ... would it be
possible to move the ACPI-related code into a new file, say fdc-acpi.c,
instead and only compile that if both, CONFIG_FDC and CONFIG_ACPI are
enabled?
Thomas
next prev parent reply other threads:[~2020-06-17 8:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 7:11 [PATCH v9 00/10] acpi: i386 tweaks Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs Gerd Hoffmann
2020-06-17 7:31 ` Philippe Mathieu-Daudé
2020-06-17 7:11 ` [PATCH v9 02/10] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-06-17 8:40 ` Thomas Huth [this message]
2020-06-17 11:31 ` Gerd Hoffmann
2020-06-17 11:34 ` Thomas Huth
2020-06-18 20:07 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 03/10] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 04/10] floppy: move cmos_get_fd_drive_type() from pc Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-06-18 20:05 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 07/10] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-06-18 20:08 ` Michael S. Tsirkin
2020-06-17 7:11 ` [PATCH v9 09/10] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-06-17 7:11 ` [PATCH v9 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-06-17 7:24 ` [PATCH v9 00/10] acpi: i386 tweaks no-reply
2020-06-17 7:42 ` no-reply
2020-06-17 7:47 ` no-reply
2020-06-18 20:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ad00f7-c7f2-ed80-01a3-8d8c6aa9fba9@redhat.com \
--to=thuth@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).