From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: npiggin@gmail.com, danielhb413@gmail.com, clg@kaod.org,
david@gibson.dropbear.id.au, harshpb@linux.ibm.com,
dave@treblig.org, jasowang@redhat.com, michael.roth@amd.com,
kkostiuk@redhat.com, mst@redhat.com, david@redhat.com,
kraxel@redhat.com, marcandre.lureau@redhat.com,
qemu-ppc@nongnu.org
Subject: Re: [PATCH 4/7] ui/qmp-cmds: Improve two error messages
Date: Tue, 31 Oct 2023 15:46:52 +0100 [thread overview]
Message-ID: <62b7af6c-8091-2ee1-cc4d-01cf7c9ebfcb@linaro.org> (raw)
In-Reply-To: <20231031111059.3407803-5-armbru@redhat.com>
On 31/10/23 12:10, Markus Armbruster wrote:
> set_password with "protocol": "vnc" supports only "connected": "keep".
> Any other value is rejected with
>
> Invalid parameter 'connected'
>
> Improve this to
>
> parameter 'connected' must be 'keep' when 'protocol' is 'vnc'
>
> client_migrate_info requires "port" or "tls-port". When both are
> missing, it fails with
>
> Parameter 'port/tls-port' is missing
>
> Improve this to
>
> parameter 'port' or 'tls-port' is required
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ui/ui-qmp-cmds.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-31 14:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 11:10 [PATCH 0/7] Miscellaneous error message improvements Markus Armbruster
2023-10-31 11:10 ` [PATCH 1/7] spapr/pci: Correct "does not support hotplugging error messages Markus Armbruster
2023-11-01 20:52 ` Daniel Henrique Barboza
2023-11-01 21:11 ` BALATON Zoltan
2023-11-15 7:07 ` Markus Armbruster
2023-10-31 11:10 ` [PATCH 2/7] hmp: Improve sync-profile error message Markus Armbruster
2023-10-31 14:05 ` Philippe Mathieu-Daudé
2023-10-31 16:59 ` Dr. David Alan Gilbert
2023-10-31 11:10 ` [PATCH 3/7] qga: Improve guest-exec-status " Markus Armbruster
2023-10-31 11:24 ` Konstantin Kostiuk
2023-10-31 14:05 ` Philippe Mathieu-Daudé
2023-10-31 11:10 ` [PATCH 4/7] ui/qmp-cmds: Improve two error messages Markus Armbruster
2023-10-31 14:46 ` Philippe Mathieu-Daudé [this message]
2023-10-31 11:10 ` [PATCH 5/7] net: Fix a misleading error message Markus Armbruster
2023-10-31 11:10 ` [PATCH 6/7] balloon: " Markus Armbruster
2023-10-31 12:25 ` David Hildenbrand
2023-10-31 12:43 ` Michael S. Tsirkin
2023-11-02 6:57 ` Mario Casquero
2023-10-31 11:10 ` [PATCH 7/7] target/i386/cpu: Improve error message for property "vendor" Markus Armbruster
2023-10-31 14:07 ` Philippe Mathieu-Daudé
2023-11-15 7:13 ` Markus Armbruster
2023-11-17 9:14 ` [PATCH 0/7] Miscellaneous error message improvements Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b7af6c-8091-2ee1-cc4d-01cf7c9ebfcb@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=dave@treblig.org \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).