From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:51434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj192-0007sj-Sf for qemu-devel@nongnu.org; Mon, 14 Jan 2019 07:15:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj192-00087S-2P for qemu-devel@nongnu.org; Mon, 14 Jan 2019 07:15:08 -0500 References: <20181213162727.17438-1-lvivier@redhat.com> From: Max Reitz Message-ID: <62bd556c-93e2-d5d0-117c-7e3b8a28ea1c@redhat.com> Date: Mon, 14 Jan 2019 13:14:53 +0100 MIME-Version: 1.0 In-Reply-To: <20181213162727.17438-1-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, qemu-block@nongnu.org, Liu Yuan , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Kevin Wolf , "Richard W.M. Jones" On 13.12.18 17:27, Laurent Vivier wrote: > Convert all the remaining uses of DPRINTF() in the directory block. > > Compiled for all target but only tested with "make check" > > v2: replace "sd_" prefix by "sheepdog_" > remove the dot at the end of the text strings > use %zu with size_t > change an uint64_t to int64_t to match % PRIi64 > > Laurent Vivier (4): > block/ssh: Convert from DPRINTF() macro to trace events > block/curl: Convert from DPRINTF() macro to trace events > block/file-posix: Convert from DPRINTF() macro to trace events > block/sheepdog: Convert from DPRINTF() macro to trace events Applied to my block branch, with three fixes (Philippe asked me to do one, so what are two more O:-)): - Patch 1: Fixed ssh_{read,write}_return's @ret sign - Patch 3: Moved the pointer asterisk in file_xfs_discard from type to name - Patch 4: Fixed sheepdog_snapshot_create_inode's format string to use PRIx32 instead of %x for uint32_ts (https://git.xanclic.moe/XanClic/qemu/commits/branch/block) Thanks! Max