From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion
Date: Tue, 15 Aug 2017 09:21:49 -0500 [thread overview]
Message-ID: <62ce5bf4-492f-8026-62a0-0ce42226dbfe@redhat.com> (raw)
In-Reply-To: <20170815130740.31229-4-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On 08/15/2017 08:07 AM, Fam Zheng wrote:
> As in the case of nbd_export_new(), bdrv_invalidate_cache() can be
> called when migration is still in progress. In this case we are not
> ready to tighten the shared permissions fenced by blk->disable_perm.
>
> Defer to a VM state change handler.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/block-backend.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-08-15 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:07 [Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration Fam Zheng
2017-08-15 13:07 ` [Qemu-devel] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs Fam Zheng
2017-08-15 13:59 ` Eric Blake
2017-08-15 13:07 ` [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache Fam Zheng
2017-08-15 14:16 ` Eric Blake
2017-08-15 13:07 ` [Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion Fam Zheng
2017-08-15 14:21 ` Eric Blake [this message]
2017-08-15 13:07 ` [Qemu-devel] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192 Fam Zheng
2017-08-15 14:26 ` Eric Blake
2017-08-18 14:14 ` [Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ce5bf4-492f-8026-62a0-0ce42226dbfe@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).