qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerhard Wiesinger <lists@wiesinger.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12
Date: Sat, 28 Oct 2017 20:13:38 +0200	[thread overview]
Message-ID: <62d3868d-a2dd-d606-f1f1-1c05174c4b57@wiesinger.com> (raw)
In-Reply-To: <c0ca5671-790a-2e9b-b1d8-fecd6802ad79@redhat.com>

On 10.10.2017 16:16, Paolo Bonzini wrote:
> On 27/09/2017 21:31, Gerhard Wiesinger wrote:
>> On 15.09.2017 19:07, Paolo Bonzini wrote:
>>> On 15/09/2017 16:43, Gerhard Wiesinger wrote:
>>>> On 27.08.2017 20:55, Paolo Bonzini wrote:
>>>>> Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" <lists@wiesinger.com
>>>>> <mailto:lists@wiesinger.com>> ha scritto:
>>>>>
>>>>>       On 27.08.2017 14 <tel:27.08.2017%2014>:03, Paolo Bonzini wrote:
>>>>>
>>>>>
>>>>>           We will revert the patch, but 4.13.0 will not have the fix.
>>>>>           Expect it in later stable kernels (because vacations).
>>>>>
>>>>>
>>>>>       Thnx. Why will 4.13.0 NOT have the fix?
>>>>>
>>>>>
>>>>> Because maintainers are on vacation! :-)
>>>>>
>>>>>
>>>> Hello Paolo,
>>>>
>>>> Any update on this for 4.12 and 4.13 kernels?
>>> A late fix is better than a wrong fix.  Hope to get to it next week!
>> Hello Paolo,
>>
>> Any update? Thnx.
> Hey, I have a patch now.  Any volunteers for testing it?
>
> This is on top of 4.13.
>
> Paolo
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c6ef2940119b..c29bf36485fd 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -200,6 +200,10 @@ struct loaded_vmcs {
>   	int cpu;
>   	bool launched;
>   	bool nmi_known_unmasked;
> +	/* Support for vnmi-less CPUs */
> +	int soft_vnmi_blocked;
> +	ktime_t entry_time;
> +	s64 vnmi_blocked_time;
>   	struct list_head loaded_vmcss_on_cpu_link;
>   };
>   

Hello Paolo,

The patch does not apply, 1st hunk FAILED.
cat arch/x86/kvm/vmx.c.rej
--- arch/x86/kvm/vmx.c
+++ arch/x86/kvm/vmx.c
@@ -200,6 +200,10 @@ struct loaded_vmcs {
         int cpu;
         bool launched;
         bool nmi_known_unmasked;
+       /* Support for vnmi-less CPUs */
+       int soft_vnmi_blocked;
+       ktime_t entry_time;
+       s64 vnmi_blocked_time;
         struct list_head loaded_vmcss_on_cpu_link;
  };

Tried it to apply against, doesn't look to fit:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/kvm/vmx.c?h=v4.13.10#n197
https://koji.fedoraproject.org/koji/buildinfo?buildID=991441

Will then recompile and test.

Thnx.

Ciao,
Gerhard

  parent reply	other threads:[~2017-10-28 18:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 20:58 [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12 Gerhard Wiesinger
2017-08-17 21:14 ` Gerhard Wiesinger
2017-08-27  7:47   ` Gerhard Wiesinger
     [not found]     ` <CABgObfYzngJPgS9agXMrRENVD_e+3Hm=y+KD5dp9na8jNwuumw@mail.gmail.com>
2017-08-27 12:03       ` Paolo Bonzini
2017-08-27 14:45         ` Gerhard Wiesinger
2017-08-27 18:55           ` Paolo Bonzini
2017-09-15 14:43             ` Gerhard Wiesinger
2017-09-15 17:07               ` Paolo Bonzini
2017-09-27 19:31                 ` Gerhard Wiesinger
     [not found]                   ` <c0ca5671-790a-2e9b-b1d8-fecd6802ad79@redhat.com>
2017-10-28 18:13                     ` Gerhard Wiesinger [this message]
     [not found]                       ` <c0591212-71a6-eb22-9550-2e17cd44324c@wiesinger.com>
     [not found]                         ` <fd1a2e70-0b37-2568-f408-b4616b70ec6e@redhat.com>
2017-11-11  7:27                           ` Gerhard Wiesinger
2017-08-27 14:59         ` Gerhard Wiesinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62d3868d-a2dd-d606-f1f1-1c05174c4b57@wiesinger.com \
    --to=lists@wiesinger.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).