From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CA91C7EE29 for ; Wed, 7 Jun 2023 08:29:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6oXJ-0000tr-Vg; Wed, 07 Jun 2023 04:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6oXI-0000tZ-VW for qemu-devel@nongnu.org; Wed, 07 Jun 2023 04:28:56 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6oXH-0002Ol-HK for qemu-devel@nongnu.org; Wed, 07 Jun 2023 04:28:56 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-30e412a852dso2674925f8f.0 for ; Wed, 07 Jun 2023 01:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686126534; x=1688718534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8ymjBykz6oPkeD2DnN/+SlsP633S5A1gJPG1IcrUGQU=; b=CMNu3B2irewPXFGkFCykjhzSkjfgLf5XHuLQqIM29C/N71De//ASQzev0vxJYlmBrR 2oMlIt4YunpjzwX2OOkwOMcEswpcGOx0sTBluTb+13rXsfoxbOnx3NZ4U0Bkrlb51q0o MlT15Hgk8mxEKZWt2ilBVd2nZsCvhooi7ky7EEA9tuIMb5m2vzyEFj5eHZrHCeqOLTc/ 4shAkMjmbEgB0PZDDrQnodmVQL095BtKDfHeFYMlV3u1o8Th43EFkaz2pDsV49Qu6Ros zAy0ArKD6ryMYey7lGYVgVPo7krMcpooJOWHmsDelNepkKCC11AZw+OZ/771Is7uQncn X3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686126534; x=1688718534; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ymjBykz6oPkeD2DnN/+SlsP633S5A1gJPG1IcrUGQU=; b=gLWgbxfzeIvSv6L38x2gyoiTNu06WM0/coITzSndvuqO75KmMWsGdoSt8dGjt9aA+u 3B6ODt2wOpFfVkHiFBILie4bTyQn4y96PBjXiTnm0+chKvXNH8Bp6hQqw5I5/gqAEwa6 TwDhUgOHGUzfqCxft47OnsEPA7lse4iRt7XHk4W/gpQvCgTfi3HsP/BvALYko5Ar0ePo uJ3aPH3uqrEpAe4UMLAKae2zO+WiMcMtTg6wJ4/cJcAWuFjASajm3I8WFkcdtgwSVq39 USYpd5wlwpSqtp6H0mPQOOx14rMrvnFRPpqdq4YC4O/kte8j2QYeywdE70ujrmY3EyVo hntQ== X-Gm-Message-State: AC+VfDwiU05jdzonRg/tZNrQAeZp5O2q401xzo5AIlqPblv4vFK6iD7D TlwCGDxdCNFE6OQJH4wOGO78yA== X-Google-Smtp-Source: ACHHUZ6CHEcHbUZ+NzsIEW0rIKaUVAc7Mcai2MyGMRCcEXcEVTb8SvhDGAJQj8b4ohn7Nnwzybmgew== X-Received: by 2002:adf:dd05:0:b0:30a:e378:76e with SMTP id a5-20020adfdd05000000b0030ae378076emr3358951wrm.64.1686126534031; Wed, 07 Jun 2023 01:28:54 -0700 (PDT) Received: from [192.168.69.115] (bd137-h02-176-184-46-52.dsl.sta.abo.bbox.fr. [176.184.46.52]) by smtp.gmail.com with ESMTPSA id d6-20020a5d5386000000b00307c46f4f08sm14797784wrv.79.2023.06.07.01.28.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 01:28:53 -0700 (PDT) Message-ID: <62e69c35-4869-8cc3-5983-9f83ff649da9@linaro.org> Date: Wed, 7 Jun 2023 10:28:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral Content-Language: en-US To: Joel Stanley , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Peter Maydell , Andrew Jeffery , Alistair Francis References: <20230607043943.1837186-1-clg@kaod.org> <20230607043943.1837186-5-clg@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/6/23 10:06, Joel Stanley wrote: > On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: >> >> Boards will use this new property to identify the device CS line and >> wire the SPI controllers accordingly. > > "addr" and not "cs" or even "chip-select"? "chip-select" is a good suggestion! > Reviewed-by: Joel Stanley > >> >> Cc: Alistair Francis >> Reviewed-by: Philippe Mathieu-Daudé >> Signed-off-by: Cédric Le Goater >> --- >> include/hw/ssi/ssi.h | 3 +++ >> hw/ssi/ssi.c | 7 +++++++ >> 2 files changed, 10 insertions(+)