qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PULL 23/24] linux-user: Provide safe_syscall for s390x
Date: Fri, 24 Jun 2016 12:53:18 +0300	[thread overview]
Message-ID: <62e6cabe0e15f36e61cf4be05598e2ef26483d9f.1466760944.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1466760944.git.riku.voipio@linaro.org>

From: Richard Henderson <rth@twiddle.net>

Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/host/s390x/hostdep.h          | 23 ++++++++
 linux-user/host/s390x/safe-syscall.inc.S | 90 ++++++++++++++++++++++++++++++++
 2 files changed, 113 insertions(+)
 create mode 100644 linux-user/host/s390x/safe-syscall.inc.S

diff --git a/linux-user/host/s390x/hostdep.h b/linux-user/host/s390x/hostdep.h
index 7609bf5..e95871c 100644
--- a/linux-user/host/s390x/hostdep.h
+++ b/linux-user/host/s390x/hostdep.h
@@ -12,4 +12,27 @@
 #ifndef QEMU_HOSTDEP_H
 #define QEMU_HOSTDEP_H
 
+/* We have a safe-syscall.inc.S */
+#define HAVE_SAFE_SYSCALL
+
+#ifndef __ASSEMBLER__
+
+/* These are defined by the safe-syscall.inc.S file */
+extern char safe_syscall_start[];
+extern char safe_syscall_end[];
+
+/* Adjust the signal context to rewind out of safe-syscall if we're in it */
+static inline void rewind_if_in_safe_syscall(void *puc)
+{
+    struct ucontext *uc = puc;
+    unsigned long *pcreg = &uc->uc_mcontext.psw.addr;
+
+    if (*pcreg > (uintptr_t)safe_syscall_start
+        && *pcreg < (uintptr_t)safe_syscall_end) {
+        *pcreg = (uintptr_t)safe_syscall_start;
+    }
+}
+
+#endif /* __ASSEMBLER__ */
+
 #endif
diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
new file mode 100644
index 0000000..f1b446a
--- /dev/null
+++ b/linux-user/host/s390x/safe-syscall.inc.S
@@ -0,0 +1,90 @@
+/*
+ * safe-syscall.inc.S : host-specific assembly fragment
+ * to handle signals occurring at the same time as system calls.
+ * This is intended to be included by linux-user/safe-syscall.S
+ *
+ * Written by Richard Henderson <rth@twiddle.net>
+ * Copyright (C) 2016 Red Hat, Inc.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+	.global safe_syscall_base
+	.global safe_syscall_start
+	.global safe_syscall_end
+	.type	safe_syscall_base, @function
+
+	/* This is the entry point for making a system call. The calling
+	 * convention here is that of a C varargs function with the
+	 * first argument an 'int *' to the signal_pending flag, the
+	 * second one the system call number (as a 'long'), and all further
+	 * arguments being syscall arguments (also 'long').
+	 * We return a long which is the syscall's return value, which
+	 * may be negative-errno on failure. Conversion to the
+	 * -1-and-errno-set convention is done by the calling wrapper.
+	 */
+safe_syscall_base:
+	.cfi_startproc
+	stmg	%r6,%r15,48(%r15)	/* save all call-saved registers */
+	.cfi_offset %r15,-40
+	.cfi_offset %r14,-48
+	.cfi_offset %r13,-56
+	.cfi_offset %r12,-64
+	.cfi_offset %r11,-72
+	.cfi_offset %r10,-80
+	.cfi_offset %r9,-88
+	.cfi_offset %r8,-96
+	.cfi_offset %r7,-104
+	.cfi_offset %r6,-112
+	lgr	%r1,%r15
+	lg	%r0,8(%r15)		/* load eos */
+	aghi	%r15,-160
+	.cfi_adjust_cfa_offset 160
+	stg	%r1,0(%r15)		/* store back chain */
+	stg	%r0,8(%r15)		/* store eos */
+
+	/* The syscall calling convention isn't the same as the
+	 * C one:
+	 * we enter with r2 == *signal_pending
+	 *               r3 == syscall number
+	 *               r4, r5, r6, (stack) == syscall arguments
+	 *               and return the result in r2
+	 * and the syscall instruction needs
+	 *               r1 == syscall number
+	 *               r2 ... r7 == syscall arguments
+	 *               and returns the result in r2
+	 * Shuffle everything around appropriately.
+	 */
+	lgr	%r8,%r2			/* signal_pending pointer */
+	lgr	%r1,%r3			/* syscall number */
+	lgr	%r2,%r4			/* syscall args */
+	lgr	%r3,%r5
+	lgr	%r4,%r6
+	lmg	%r5,%r7,320(%r15)
+
+	/* This next sequence of code works in conjunction with the
+	 * rewind_if_safe_syscall_function(). If a signal is taken
+	 * and the interrupted PC is anywhere between 'safe_syscall_start'
+	 * and 'safe_syscall_end' then we rewind it to 'safe_syscall_start'.
+	 * The code sequence must therefore be able to cope with this, and
+	 * the syscall instruction must be the final one in the sequence.
+	 */
+safe_syscall_start:
+	/* if signal_pending is non-zero, don't do the call */
+	lt	%r0,0(%r8)
+	jne	2f
+	svc	0
+safe_syscall_end:
+
+1:	lg	%r15,0(%r15)		/* load back chain */
+	.cfi_remember_state
+	.cfi_adjust_cfa_offset -160
+	lmg	%r6,%r15,48(%r15)	/* load saved registers */
+	br	%r14
+	.cfi_restore_state
+2:	lghi	%r2, -TARGET_ERESTARTSYS
+	j	1b
+	.cfi_endproc
+
+	.size	safe_syscall_base, .-safe_syscall_base
-- 
2.1.4

  parent reply	other threads:[~2016-06-24  9:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  9:52 [Qemu-devel] [PULL 00/24] linux-user changes riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 01/24] linux-user: Avoid possible misalignment in host_to_target_siginfo() riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 02/24] linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl() riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 03/24] linux-user: Use safe_syscall wrapper for fcntl riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 04/24] linux-user: Don't use sigfillset() on uc->uc_sigmask riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 05/24] configure: Don't override ARCH=unknown if enabling TCI riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 06/24] configure: Don't allow user-only targets for unknown CPU architectures riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 07/24] user-exec: Delete now-unused hppa and m68k cpu_signal_handler() code riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 08/24] user-exec: Remove unused code for OSX hosts riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 09/24] linux-user: Create a hostdep.h for each host architecture riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 10/24] linux-user: Fix wrong type used for argument to rt_sigqueueinfo riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 11/24] linux-user: Support F_GETPIPE_SZ and F_SETPIPE_SZ fcntls riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 12/24] linux-user: add socketcall() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 13/24] linux-user: add socket() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 14/24] linux-user: fix clone() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 15/24] linux-user: update get_thread_area/set_thread_area strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 16/24] linux-user: add missing return in netlink switch statement riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 17/24] linux-user: fd_trans_host_to_target_data() must process only received data riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 18/24] linux-user: don't swap NLMSG_DATA() fields riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 19/24] linux-user: fix x86_64 safe_syscall riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 20/24] linux-user: Provide safe_syscall for i386 riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 21/24] linux-user: Provide safe_syscall for arm riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 22/24] linux-user: Provide safe_syscall for aarch64 riku.voipio
2016-06-24  9:53 ` riku.voipio [this message]
2016-06-24  9:53 ` [Qemu-devel] [PULL 24/24] linux-user: Provide safe_syscall for ppc64 riku.voipio
2016-06-24 13:36 ` [Qemu-devel] [PULL 00/24] linux-user changes Peter Maydell
2016-06-26 10:34   ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62e6cabe0e15f36e61cf4be05598e2ef26483d9f.1466760944.git.riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).