From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5zF-0001Ef-8R for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn5zC-00040a-1c for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5zB-00040V-Ny for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:32:29 -0400 References: <147455590865.8519.11191009507297313736.stgit@brijesh-build-machine> <147455597948.8519.11161523289950636174.stgit@brijesh-build-machine> From: Eric Blake Message-ID: <62efa247-2795-2cb7-7168-07cdeda53fef@redhat.com> Date: Thu, 22 Sep 2016 10:32:27 -0500 MIME-Version: 1.0 In-Reply-To: <147455597948.8519.11161523289950636174.stgit@brijesh-build-machine> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cdcCWQFLWtJfcEBdHlde0BiIfUPGOh8ge" Subject: Re: [Qemu-devel] [RFC PATCH v2 07/16] hmp: display memory encryption support in 'info kvm' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh , ehabkost@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cdcCWQFLWtJfcEBdHlde0BiIfUPGOh8ge From: Eric Blake To: Brijesh Singh , ehabkost@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net Message-ID: <62efa247-2795-2cb7-7168-07cdeda53fef@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 07/16] hmp: display memory encryption support in 'info kvm' References: <147455590865.8519.11191009507297313736.stgit@brijesh-build-machine> <147455597948.8519.11161523289950636174.stgit@brijesh-build-machine> In-Reply-To: <147455597948.8519.11161523289950636174.stgit@brijesh-build-machine> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2016 09:52 AM, Brijesh Singh wrote: > update 'info kvm' to display the memory encryption support. >=20 > (qemu) info kvm > kvm support: enabled > memory encryption: disabled >=20 > Signed-off-by: Brijesh Singh > --- > +++ b/qapi-schema.json > @@ -99,9 +99,12 @@ > # > # @present: true if KVM acceleration is built into this executable > # > -# Since: 0.14.0 > +# @mem_encryption: true if Memory Encryption is active > +# > +# Since: 2.8.0 Not quite right. The KvmInfo struct is still since 0.14.0, only the mem_encryption member is new. And new members should be spelled with '-' rather than '_', if there is no other '_' in the struct. So you want: # @present: true if KVM acceleration is built into this executable # # @mem-encryption: true if Memory Encryption is active (since 2.8) # # Since: 0.14.0 > ## > -{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool'} = } > +{ 'struct': 'KvmInfo', 'data': {'enabled': 'bool', 'present': 'bool', > + 'mem_encryption' : 'bool'} } and with the corresponding spelling fix here. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cdcCWQFLWtJfcEBdHlde0BiIfUPGOh8ge Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4/mLAAoJEKeha0olJ0Nqy3cH/AgxComuIDBRROEIew3t+0bq tz7SlwoIicQSNidRMyXfftVA+hC23EWM4Xzvue4Y1k3RE7oZriQuqshlSthXAwTH A9EmQMw07RNpITfJStWzknXUiYhY9L9/UqxqhQ5vJYidQxmKbaDOLyeDXJV1ZsB9 gi8B1X9bK4m9Y4xc7HWBA5K3DsO+A10M2YhsF5f7WNNzsHBYkEWiQl1QnuK05ueR TEBsQS3vn9JMBaTVk0cwqBy9lrwNptVFNIReOm7UUWd8Eal7T3OiGY4L0C0ahuQS XyWXbqqC1pnAja6lU9grq8T2AT6Nnmj94hIzKHp5vY/YwMLDzrWzT9PS8UfeGyo= =YKqO -----END PGP SIGNATURE----- --cdcCWQFLWtJfcEBdHlde0BiIfUPGOh8ge--