From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH v2] vl: Abort if multiple machines are registered as default
Date: Fri, 7 Feb 2020 12:28:25 +0000 [thread overview]
Message-ID: <62f09eee-631e-8831-120e-82468aec5fc9@linaro.org> (raw)
In-Reply-To: <20200207112729.28554-1-philmd@redhat.com>
On 2/7/20 11:27 AM, Philippe Mathieu-Daudé wrote:
> + default_count += !!mc->is_default;
I'd prefer we simply change mc->is_default to bool.
There's no good reason for it to be type int, afaics.
In the meantime, there are no settings of is_default outside {0,1}, so you
could just drop the !! for now.
r~
prev parent reply other threads:[~2020-02-07 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:27 [PATCH v2] vl: Abort if multiple machines are registered as default Philippe Mathieu-Daudé
2020-02-07 12:28 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f09eee-631e-8831-120e-82468aec5fc9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).