From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
Qemu-block <qemu-block@nongnu.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Alistair Francis" <alistair@alistair23.me>,
"Fabien Chouteau" <chouteau@adacore.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Peter Chubb" <peter.chubb@nicta.com.au>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Richard Henderson" <rth@twiddle.net>,
"Kevin Wolf" <kwolf@redhat.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>,
"Michael Walle" <michael@walle.cc>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH v2 05/32] hw/arm: Use memory_region_init_rom() with read-only regions
Date: Tue, 25 Feb 2020 11:02:49 +0100 [thread overview]
Message-ID: <62f0a8f5-82ff-e543-964a-a8759169e01f@redhat.com> (raw)
In-Reply-To: <CAKmqyKPcWkN4fhu+kmU8d+wsPLt_4BJB74Tao-P7nJpBQa1jZA@mail.gmail.com>
On 2/24/20 10:20 PM, Alistair Francis wrote:
> On Mon, Feb 24, 2020 at 12:51 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
>>
>> This commit was produced with the Coccinelle script
>> scripts/coccinelle/memory-region-housekeeping.cocci.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> This looks good for the ROM regions, for the flash regions this
> doesn't change the current functionality but I'm not sure it's any
> clearer.
Less code makes easier review.
These regions behave as ROM on the bus, any write to the address space
is illegal (they are programmable via I/O registers in another address
space).
>
> Either way though:
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Thanks, do you want me to improve the commit description?
>
> Alistair
>
>> ---
>> hw/arm/exynos4210.c | 3 +--
>> hw/arm/mainstone.c | 3 +--
>> hw/arm/omap_sx1.c | 6 ++----
>> hw/arm/palm.c | 3 +--
>> hw/arm/spitz.c | 3 +--
>> hw/arm/stellaris.c | 3 +--
>> hw/arm/tosa.c | 3 +--
>> 7 files changed, 8 insertions(+), 16 deletions(-)
>>
>> diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
>> index 59a27bdd68..3af6502a5e 100644
>> --- a/hw/arm/exynos4210.c
>> +++ b/hw/arm/exynos4210.c
>> @@ -311,9 +311,8 @@ static void exynos4210_realize(DeviceState *socdev, Error **errp)
>> &s->chipid_mem);
>>
>> /* Internal ROM */
>> - memory_region_init_ram(&s->irom_mem, NULL, "exynos4210.irom",
>> + memory_region_init_rom(&s->irom_mem, NULL, "exynos4210.irom",
>> EXYNOS4210_IROM_SIZE, &error_fatal);
>> - memory_region_set_readonly(&s->irom_mem, true);
>> memory_region_add_subregion(system_mem, EXYNOS4210_IROM_BASE_ADDR,
>> &s->irom_mem);
>> /* mirror of iROM */
>> diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c
>> index 6e64dfab50..05a806b422 100644
>> --- a/hw/arm/mainstone.c
>> +++ b/hw/arm/mainstone.c
>> @@ -125,9 +125,8 @@ static void mainstone_common_init(MemoryRegion *address_space_mem,
>> /* Setup CPU & memory */
>> mpu = pxa270_init(address_space_mem, mainstone_binfo.ram_size,
>> machine->cpu_type);
>> - memory_region_init_ram(rom, NULL, "mainstone.rom", MAINSTONE_ROM,
>> + memory_region_init_rom(rom, NULL, "mainstone.rom", MAINSTONE_ROM,
>> &error_fatal);
>> - memory_region_set_readonly(rom, true);
>> memory_region_add_subregion(address_space_mem, 0, rom);
>>
>> #ifdef TARGET_WORDS_BIGENDIAN
>> diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c
>> index be245714db..6c3fd1b271 100644
>> --- a/hw/arm/omap_sx1.c
>> +++ b/hw/arm/omap_sx1.c
>> @@ -126,9 +126,8 @@ static void sx1_init(MachineState *machine, const int version)
>> mpu = omap310_mpu_init(dram, machine->cpu_type);
>>
>> /* External Flash (EMIFS) */
>> - memory_region_init_ram(flash, NULL, "omap_sx1.flash0-0", flash_size,
>> + memory_region_init_rom(flash, NULL, "omap_sx1.flash0-0", flash_size,
>> &error_fatal);
>> - memory_region_set_readonly(flash, true);
>> memory_region_add_subregion(address_space, OMAP_CS0_BASE, flash);
>>
>> memory_region_init_io(&cs[0], NULL, &static_ops, &cs0val,
>> @@ -168,9 +167,8 @@ static void sx1_init(MachineState *machine, const int version)
>> if ((version == 1) &&
>> (dinfo = drive_get(IF_PFLASH, 0, fl_idx)) != NULL) {
>> MemoryRegion *flash_1 = g_new(MemoryRegion, 1);
>> - memory_region_init_ram(flash_1, NULL, "omap_sx1.flash1-0",
>> + memory_region_init_rom(flash_1, NULL, "omap_sx1.flash1-0",
>> flash1_size, &error_fatal);
>> - memory_region_set_readonly(flash_1, true);
>> memory_region_add_subregion(address_space, OMAP_CS1_BASE, flash_1);
>>
>> memory_region_init_io(&cs[1], NULL, &static_ops, &cs1val,
>> diff --git a/hw/arm/palm.c b/hw/arm/palm.c
>> index 72eca8cc55..265d5891a6 100644
>> --- a/hw/arm/palm.c
>> +++ b/hw/arm/palm.c
>> @@ -206,9 +206,8 @@ static void palmte_init(MachineState *machine)
>> mpu = omap310_mpu_init(dram, machine->cpu_type);
>>
>> /* External Flash (EMIFS) */
>> - memory_region_init_ram(flash, NULL, "palmte.flash", flash_size,
>> + memory_region_init_rom(flash, NULL, "palmte.flash", flash_size,
>> &error_fatal);
>> - memory_region_set_readonly(flash, true);
>> memory_region_add_subregion(address_space_mem, OMAP_CS0_BASE, flash);
>>
>> memory_region_init_io(&cs[0], NULL, &static_ops, &cs0val, "palmte-cs0",
>> diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
>> index e001088103..1d27399721 100644
>> --- a/hw/arm/spitz.c
>> +++ b/hw/arm/spitz.c
>> @@ -924,8 +924,7 @@ static void spitz_common_init(MachineState *machine,
>>
>> sl_flash_register(mpu, (model == spitz) ? FLASH_128M : FLASH_1024M);
>>
>> - memory_region_init_ram(rom, NULL, "spitz.rom", SPITZ_ROM, &error_fatal);
>> - memory_region_set_readonly(rom, true);
>> + memory_region_init_rom(rom, NULL, "spitz.rom", SPITZ_ROM, &error_fatal);
>> memory_region_add_subregion(address_space_mem, 0, rom);
>>
>> /* Setup peripherals */
>> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
>> index 221a78674e..d136ba1a92 100644
>> --- a/hw/arm/stellaris.c
>> +++ b/hw/arm/stellaris.c
>> @@ -1300,9 +1300,8 @@ static void stellaris_init(MachineState *ms, stellaris_board_info *board)
>> sram_size = ((board->dc0 >> 18) + 1) * 1024;
>>
>> /* Flash programming is done via the SCU, so pretend it is ROM. */
>> - memory_region_init_ram(flash, NULL, "stellaris.flash", flash_size,
>> + memory_region_init_rom(flash, NULL, "stellaris.flash", flash_size,
>> &error_fatal);
>> - memory_region_set_readonly(flash, true);
>> memory_region_add_subregion(system_memory, 0, flash);
>>
>> memory_region_init_ram(sram, NULL, "stellaris.sram", sram_size,
>> diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
>> index 4d95a1f3e2..5dee2d76c6 100644
>> --- a/hw/arm/tosa.c
>> +++ b/hw/arm/tosa.c
>> @@ -226,8 +226,7 @@ static void tosa_init(MachineState *machine)
>>
>> mpu = pxa255_init(address_space_mem, tosa_binfo.ram_size);
>>
>> - memory_region_init_ram(rom, NULL, "tosa.rom", TOSA_ROM, &error_fatal);
>> - memory_region_set_readonly(rom, true);
>> + memory_region_init_rom(rom, NULL, "tosa.rom", TOSA_ROM, &error_fatal);
>> memory_region_add_subregion(address_space_mem, 0, rom);
>>
>> tmio = tc6393xb_init(address_space_mem, 0x10000000,
>> --
>> 2.21.1
>>
>>
>
next prev parent reply other threads:[~2020-02-25 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 20:47 [PATCH v2 00/32] hw: Sanitize various MemoryRegion uses Philippe Mathieu-Daudé
2020-02-24 20:47 ` [PATCH v2 01/32] memory: Correctly return alias region type Philippe Mathieu-Daudé
2020-02-24 21:14 ` Alistair Francis
2020-02-24 20:47 ` [PATCH v2 02/32] memory: Simplify memory_region_init_rom_nomigrate() to ease review Philippe Mathieu-Daudé
2020-02-24 20:47 ` [PATCH v2 03/32] scripts/cocci: Rename memory-region-{init-ram -> housekeeping} Philippe Mathieu-Daudé
2020-02-24 20:48 ` [PATCH v2 04/32] scripts/cocci: Patch to replace memory_region_init_{ram, readonly -> rom} Philippe Mathieu-Daudé
2020-02-24 20:48 ` [PATCH v2 05/32] hw/arm: Use memory_region_init_rom() with read-only regions Philippe Mathieu-Daudé
2020-02-24 21:20 ` Alistair Francis
2020-02-25 10:02 ` Philippe Mathieu-Daudé [this message]
2020-02-25 16:15 ` Alistair Francis
2020-02-24 20:48 ` [PATCH v2 06/32] hw/display: " Philippe Mathieu-Daudé
2020-02-24 20:48 ` [PATCH v2 07/32] hw/mips: " Philippe Mathieu-Daudé
2020-02-24 20:48 ` [PATCH v2 08/32] hw/m68k: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f0a8f5-82ff-e543-964a-a8759169e01f@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=amarkovic@wavecomp.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=chouteau@adacore.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=i.mitsyanko@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcd@tribudubois.net \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).