From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 8/8] iotests/129: Clean up pylint and mypy complaints
Date: Wed, 13 Jan 2021 13:04:20 -0600 [thread overview]
Message-ID: <62ff3eb3-e063-8100-aa1d-b0a93e660a7d@redhat.com> (raw)
In-Reply-To: <20210113175752.403022-9-mreitz@redhat.com>
On 1/13/21 11:57 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/129 | 6 ++++--
> tests/qemu-iotests/297 | 2 +-
> tests/qemu-iotests/297.out | 1 +
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> +++ b/tests/qemu-iotests/297
> @@ -32,7 +32,7 @@ fi
>
> # TODO: Empty this list!
> skip_files=(
> - 030 040 041 044 045 055 056 057 065 093 096 118 124 129 132 136 139 147 148
> + 030 040 041 044 045 055 056 057 065 093 096 118 124 132 136 139 147 148
> 149 151 152 155 163 165 169 194 196 199 202 203 205 206 207 208 210 211 212
> 213 216 218 219 222 224 228 234 235 236 237 238 240 242 245 246 248 255 256
Ragged right end prior to justified lines looks odd, but it's cosmetic
and not fatal to the patch.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-13 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 17:57 [PATCH v2 0/8] iotests: Fix 129 and expand 297’s reach Max Reitz
2021-01-13 17:57 ` [PATCH v2 1/8] iotests/297: Allow checking all Python test files Max Reitz
2021-01-13 19:01 ` Eric Blake
2021-01-14 9:23 ` Max Reitz
2021-01-13 19:27 ` Vladimir Sementsov-Ogievskiy
2021-01-13 20:28 ` Vladimir Sementsov-Ogievskiy
2021-01-14 9:31 ` Max Reitz
2021-01-14 10:53 ` Vladimir Sementsov-Ogievskiy
2021-01-14 9:27 ` Max Reitz
2021-01-13 17:57 ` [PATCH v2 2/8] iotests: Move try_remove to iotests.py Max Reitz
2021-01-13 19:28 ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:57 ` [PATCH v2 3/8] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-13 17:57 ` [PATCH v2 4/8] iotests/129: Do not check @busy Max Reitz
2021-01-13 17:57 ` [PATCH v2 5/8] iotests/129: Use throttle node Max Reitz
2021-01-13 19:02 ` Eric Blake
2021-01-13 20:33 ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:57 ` [PATCH v2 6/8] iotests/129: Actually test a commit job Max Reitz
2021-01-13 17:57 ` [PATCH v2 7/8] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-13 17:57 ` [PATCH v2 8/8] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-13 19:04 ` Eric Blake [this message]
2021-01-13 20:38 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ff3eb3-e063-8100-aa1d-b0a93e660a7d@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).