From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F18C433ED for ; Wed, 28 Apr 2021 00:08:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6007361401 for ; Wed, 28 Apr 2021 00:08:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6007361401 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbXkz-0000j0-8e for qemu-devel@archiver.kernel.org; Tue, 27 Apr 2021 20:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbXkI-0000H9-2Q for qemu-devel@nongnu.org; Tue, 27 Apr 2021 20:08:02 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:34758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbXkE-0001hE-Av for qemu-devel@nongnu.org; Tue, 27 Apr 2021 20:08:01 -0400 Received: by mail-pg1-x533.google.com with SMTP id z16so2582245pga.1 for ; Tue, 27 Apr 2021 17:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QUeIwPzJ4wfzKmUFSs3zia1ajsMWz/DDoyNx6rk0OyY=; b=Dr6XdPgscbV86QMQSLJ+CupZoVVgAxuiUMl2HYrK5I5NBNMM+agtDoM5OZlNofwk5B NzLlPZaxYpBqFPntCevcLuRxMkl9wyX13fZq8rLPmTihj+Wf++ZR/V10G7T79utslN1Y MBQ2mzNBM5avv/Q2QSdIfhXKBjm1moNay1fku13V+Pilz11zMFUVzLAakORYsCS2fHgM RsHXSErp83b/JfrnI8ZwcvJ0akHsY8ik2clnKWF2dvs+olEuuC0QtXFEuWKqaWmWMnj0 eJBtxMx3utG/NLprqMAgpKVwUTAeUhAgzX2Y2Ed8/MKJDpciLCOtwH7mk4q/Z3lS5Ab6 nzUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QUeIwPzJ4wfzKmUFSs3zia1ajsMWz/DDoyNx6rk0OyY=; b=hI4IQOBhsnr+iLm86htwVugd8m3j2SlwMAkrU8Uwy73w8MF8bdhd2Q7Qzxrg60sFgo zXQkIuwvyiPgepn14856Q72K+VG4DqbwFLBxTn0TphMom/ljjaiWnzl/IgaGmsK8QKzJ +TEJipOr84RFquVr27WPsrQ99Af+ns9s4Hvh+IIH0L8F79V0ZyzHty6+zbU9dx3WLGQt Ea+gwck6t4+dAExeiFyKzZ8SA13VraRkWk3QSxqlpf3rleLIRSlc8SsAyS5nfkWaDgdw RktIoTVNQmxYEDPtQiTL+tWx2xBZsAcyg4ma21PHxogCxpL2RamIAiuWp00pLCEMY60y 7vmA== X-Gm-Message-State: AOAM531OnMcJ9GXeFoLE83C/Cvpog/bZyn/o3RFT30h3fXUVwJYX6bp1 tEzfccCCnc8NGRI4ADTT6oUtRQ== X-Google-Smtp-Source: ABdhPJx6CAr536aYpqZNjiJGiZ2GgcstZtO4bp/f/Fm8Nv+mt0E50zdR+3UZJ4Sqa1aPv+wDVA57pA== X-Received: by 2002:a63:2265:: with SMTP id t37mr23534535pgm.452.1619568475818; Tue, 27 Apr 2021 17:07:55 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id z188sm695347pgb.89.2021.04.27.17.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 17:07:52 -0700 (PDT) Subject: Re: [RFC PATCH 2/2] hw/sparc: Allow building without the leon3 machine To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210427192658.266933-1-f4bug@amsat.org> <20210427192658.266933-3-f4bug@amsat.org> From: Richard Henderson Message-ID: <6300f36d-077b-491f-5ef1-ed2126a2db7c@linaro.org> Date: Tue, 27 Apr 2021 17:07:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210427192658.266933-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabien Chouteau , Thomas Huth , Mark Cave-Ayland , KONRAD Frederic , Artyom Tarasenko Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/27/21 12:26 PM, Philippe Mathieu-Daudé wrote: > When building without the leon3 machine, we get this link failure: > > /usr/bin/ld: target_sparc_int32_helper.c.o: in function `leon3_irq_manager': > target/sparc/int32_helper.c:172: undefined reference to `leon3_irq_ack' > > This is because the leon3_irq_ack() is declared in hw/sparc/leon3.c, > which is only build when CONFIG_LEON3 is selected. > > Fix by moving the leon3_cache_control_int() / leon3_irq_manager() > (which are specific to the leon3 machine) to hw/sparc/leon3.c. > Move the trace events along (but don't rename them). > > leon3_irq_ack() is now locally used, declare it static to reduce > its scope. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC: The problem is we have hardware specific code in the > architectural translation code. I wish there was a better > alternative rather than moving this code to hw/sparc/. > --- This one seems dead obvious. I think this code should have been in hw/sparc/leon3.c to begin with. Reviewed-by: Richard Henderson r~