From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNuYj-0005o1-6L for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:40:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNuYh-0005lf-CF for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:40:48 -0500 Received: from [199.232.76.173] (port=45336 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNuYh-0005lR-7w for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:40:47 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:35225) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNuYg-00040T-Cq for qemu-devel@nongnu.org; Fri, 16 Jan 2009 14:40:47 -0500 Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id F19CD9401A9 for ; Fri, 16 Jan 2009 20:40:42 +0100 (CET) Received: from laptop (vaf26-2-82-244-111-82.fbx.proxad.net [82.244.111.82]) by smtp1-g21.free.fr (Postfix) with ESMTP id 134C5940158 for ; Fri, 16 Jan 2009 20:40:40 +0100 (CET) In-Reply-To: <4970E08E.5010707@codemonkey.ws> Subject: Re: [Qemu-devel] [6324] Return -errno on write failure (Gleb Natapov) From: "=?utf-8?q?Fran=C3=A7ois?= Revol" Date: Fri, 16 Jan 2009 20:41:04 +0100 CET Message-Id: <6310440739-BeMail@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > > The maintainer of our port didn't submit patches because he was too > > busy to clean it up AFAIK. > > I'm not even sure it'd still build on BeOS, but that'd certainly > > help > > building in Haiku. > > > > > >> So I'm not inclined to change code that conforms to ANSI unless > >> someone > >> puts the work into supporting BeOS in mainline QEMU and that said > >> work > >> doesn't require very invasive changes. > >> > > > > As per other ports, it's not invasive it's just a large diff and > > it's > > fastidious to make sure each and every occurence is fixed. > > > > Which is a good encouragement to invest the time in pushing your work > upstream. It's unfair to ask upstream QEMU to make changes to make > external ports simpler to maintain though. Who said I asked you to do it =3F I said I would. And it's not to make it simpler to maintain outside. It's just to make sure it's known, and make it simpler to push the rest upstream, because I'm used to this issue. I don't control what others do. As for me I usually send diffs early so I don't have to maintain forks because I know how time consuming it is. Fran=C3=A7ois.