From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48037)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1bpse2-0006rP-I0
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:54:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1bpsdy-0002tA-Gb
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:54:10 -0400
Received: from [59.151.112.132] (port=57314 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1bpsdw-0002r1-Gz
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 03:54:06 -0400
References: <1475147192-31228-1-git-send-email-lizhijian@cn.fujitsu.com>
	<1475147192-31228-2-git-send-email-lizhijian@cn.fujitsu.com>
	<20160930061516.GC1429@amit-lp.rh>
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Message-ID: <6327b0c2-6017-f80c-ed48-db7e9917ad25@cn.fujitsu.com>
Date: Fri, 30 Sep 2016 15:53:44 +0800
MIME-Version: 1.0
In-Reply-To: <20160930061516.GC1429@amit-lp.rh>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices
 between source and distination at the begining
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org



On 09/30/2016 02:15 PM, Amit Shah wrote:
> Hi,
>
> On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote:
>> Priviously, if the source and distination have different devices, source could goto
>> the status "paused (postmigrate)", and the distination will exit that means no qemu
>> is alive.
>>
>> After this patch, at above case, source can dectect the some error early from distination
>> and stop the migration, source keep in status "running".
>
> How would incoming migrations from previous versions work?

You are right. we need to consider more.

How about that:
we need to introduce a new section type(e.g: QEMU_VM_SECTION_DEVICE_LIST).

source side:
- at the beginning of qemu_savevm_state_begin(), send QEMU_VM_SECTION_DEVICE_LIST first
- original path

dst side:
- if we got the QEMU_VM_SECTION_DEVICE_LIST, have a check with the devices(name,version)
- otherwise original path

Please correct me.

Thanks
Zhijian

>
>
> 		Amit
>
>
>