Re: [PATCH 07/16] bsd-user: Move system call include to os-syscall.h

[Richard Henderson <richard.henderson@linaro.org>]

On 4/10/23 10:12, Warner Losh wrote:
> 
> 
> On Sat, Apr 8, 2023 at 1:08 PM Richard Henderson <richard.henderson@linaro.org 
> <mailto:richard.henderson@linaro.org>> wrote:
> 
>     On 4/5/23 14:36, Warner Losh wrote:
>      > @@ -98,11 +75,9 @@ struct target_iovec {
>      >    * sys/timex.h
>      >    */
>      >
>      > -typedef abi_long target_freebsd_suseconds_t;
>      > -
>      >   /* compare to sys/timespec.h */
>      >   struct target_freebsd_timespec {
>      > -    target_freebsd_time_t   tv_sec;     /* seconds */
>      > +    target_time_t   tv_sec;     /* seconds */
>      >       abi_long                tv_nsec;    /* and nanoseconds */
>      >   #if !defined(TARGET_I386) && TARGET_ABI_BITS == 32
>      >       abi_long _pad;
>      > @@ -120,8 +95,8 @@ struct target_freebsd__umtx_time {
>      >   };
>      >
>      >   struct target_freebsd_timeval {
>      > -    target_freebsd_time_t       tv_sec; /* seconds */
>      > -    target_freebsd_suseconds_t  tv_usec;/* and microseconds */
>      > +    target_time_t       tv_sec; /* seconds */
>      > +    target_suseconds_t  tv_usec;/* and microseconds */
> 
>     Did I miss where target_suseconds_t got defined?
>     With the context provided, you remove target_freebsd_suseconds_t but don't replace it.
> 
> 
> At the very end of the first file bsd-user/freebsd/os-syscall.h I define it.

Ah, there it is, thanks.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~