From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: paul@xen.org, qemu-devel@nongnu.org
Cc: "'Peter Maydell'" <peter.maydell@linaro.org>,
"'Stefano Stabellini'" <sstabellini@kernel.org>,
"'Eduardo Habkost'" <ehabkost@redhat.com>,
"'Michael S. Tsirkin'" <mst@redhat.com>,
"'Andrew Jeffery'" <andrew@aj.id.au>,
"'Helge Deller'" <deller@gmx.de>,
qemu-trivial@nongnu.org, qemu-arm@nongnu.org,
"'Hervé Poussineau'" <hpoussin@reactos.org>,
"'Joel Stanley'" <joel@jms.id.au>,
xen-devel@lists.xenproject.org,
"'Anthony Perard'" <anthony.perard@citrix.com>,
"'Paolo Bonzini'" <pbonzini@redhat.com>,
"'Richard Henderson'" <rth@twiddle.net>,
qemu-ppc@nongnu.org, "'Cédric Le Goater'" <clg@kaod.org>
Subject: Re: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions
Date: Mon, 1 Jun 2020 10:33:25 +0200 [thread overview]
Message-ID: <63327be6-10c1-6a8c-b4ed-cbbd085a35a8@amsat.org> (raw)
In-Reply-To: <000001d637e5$f0c4b4f0$d24e1ed0$@xen.org>
On 6/1/20 9:26 AM, Paul Durrant wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On Behalf Of Philippe Mathieu-Daudé
>> Sent: 31 May 2020 18:38
>> To: qemu-devel@nongnu.org
>> Cc: Andrew Jeffery <andrew@aj.id.au>; Helge Deller <deller@gmx.de>; Peter Maydell
>> <peter.maydell@linaro.org>; Richard Henderson <rth@twiddle.net>; Eduardo Habkost
>> <ehabkost@redhat.com>; Paul Durrant <paul@xen.org>; Hervé Poussineau <hpoussin@reactos.org>; Marcel
>> Apfelbaum <marcel.apfelbaum@gmail.com>; xen-devel@lists.xenproject.org; Paolo Bonzini
>> <pbonzini@redhat.com>; Stefano Stabellini <sstabellini@kernel.org>; Cédric Le Goater <clg@kaod.org>;
>> qemu-trivial@nongnu.org; Joel Stanley <joel@jms.id.au>; qemu-arm@nongnu.org; Michael S. Tsirkin
>> <mst@redhat.com>; Anthony Perard <anthony.perard@citrix.com>; qemu-ppc@nongnu.org; Philippe Mathieu-
>> Daudé <f4bug@amsat.org>
>> Subject: [PATCH 7/8] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions
>>
>> IEC binary prefixes ease code review: the unit is explicit.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> hw/i386/xen/xen-hvm.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
>> index 82ece6b9e7..679d74e6a3 100644
>> --- a/hw/i386/xen/xen-hvm.c
>> +++ b/hw/i386/xen/xen-hvm.c
>> @@ -9,6 +9,7 @@
>> */
>>
>> #include "qemu/osdep.h"
>> +#include "qemu/units.h"
>>
>> #include "cpu.h"
>> #include "hw/pci/pci.h"
>> @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms,
>> * Xen does not allocate the memory continuously, it keeps a
>> * hole of the size computed above or passed in.
>> */
>> - block_len = (1ULL << 32) + x86ms->above_4g_mem_size;
>> + block_len = 4 * GiB + x86ms->above_4g_mem_size;
>
> Not strictly necessary but could we retain the brackets please?
Sure.
Laurent, if this can go via your trivial@ tree, can you do the change or
you rather I resend the whole series?
>
> Paul
>
>> }
>> memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len,
>> &error_fatal);
>> --
>> 2.21.3
>
>
>
next prev parent reply other threads:[~2020-06-01 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 17:38 [PATCH 0/8] hw: Fix some incomplete memory region size Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 1/8] hw/arm/aspeed: Correct DRAM container " Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 2/8] hw/pci-host/prep: Correct RAVEN bus bridge memory " Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 3/8] hw/pci/pci_bridge: Correct pci_bridge_io " Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 4/8] hw/pci/pci_bridge: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 5/8] hw/pci-host: " Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 6/8] hw/hppa/dino: " Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 7/8] hw/i386/xen/xen-hvm: " Philippe Mathieu-Daudé
2020-06-01 7:26 ` Paul Durrant
2020-06-01 8:33 ` Philippe Mathieu-Daudé [this message]
2020-06-01 11:15 ` Philippe Mathieu-Daudé
2020-05-31 17:38 ` [PATCH 8/8] target/i386/cpu: " Philippe Mathieu-Daudé
2020-05-31 19:48 ` [PATCH 0/8] hw: Fix some incomplete memory region size Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63327be6-10c1-6a8c-b4ed-cbbd085a35a8@amsat.org \
--to=f4bug@amsat.org \
--cc=andrew@aj.id.au \
--cc=anthony.perard@citrix.com \
--cc=clg@kaod.org \
--cc=deller@gmx.de \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=joel@jms.id.au \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).