From: Stefan Berger <stefanb@linux.ibm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Ninad Palsule <ninad@linux.ibm.com>,
qemu-devel@nongnu.org, andrew@aj.id.au, clg@kaod.org
Subject: Re: [PATCH v7 0/3] Add support for TPM devices over I2C bus
Date: Mon, 27 Mar 2023 07:24:13 -0400 [thread overview]
Message-ID: <633a1c3a-6dd8-4f20-6194-a866fd9c3b7c@linux.ibm.com> (raw)
In-Reply-To: <CACPK8Xfp06JdTt32T9e=KDaBq5DURyv05OG4Ks9Bk3914_zO9g@mail.gmail.com>
On 3/27/23 07:18, Joel Stanley wrote:
> On Mon, 27 Mar 2023 at 11:11, Stefan Berger <stefanb@linux.ibm.com> wrote:
>>
>>
>>
>> On 3/26/23 21:05, Joel Stanley wrote:
>>> Hi Ninad,
>>>
>>> On Sun, 26 Mar 2023 at 22:44, Ninad Palsule <ninad@linux.ibm.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> I have incorporated review comments from Stefan. Please review.
>>>>
>>>> This drop adds support for the TPM devices attached to the I2C bus. It
>>>> only supports the TPM2 protocol. You need to run it with the external
>>>> TPM emulator like swtpm. I have tested it with swtpm.
>>>
>>> Nice work. I tested these stop cedric's aspeed-8.0 qemu tree, using
>>> the rainier machine and the openbmc dev-6.1 kernel.
>>>
>>> We get this message when booting from a kernel:
>>>
>>> [ 0.582699] tpm_tis_i2c 12-002e: 2.0 TPM (device-id 0x1, rev-id 1)
>>> [ 0.586361] tpm tpm0: A TPM error (256) occurred attempting the self test
>>> [ 0.586623] tpm tpm0: starting up the TPM manually
>>>
>>> Do we understand why the error appears?
>>
>> The firmware did not initialize the TPM 2.
>
> Which firmware are we talking about here?
This happens if either no firmware is used or the firmware doesn't know how to talk to the TPM 2.
Linux detects that the TPM 2 wasn't initialized (TPM2_Startup was not sent).
Stefan
next prev parent reply other threads:[~2023-03-27 11:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 22:44 [PATCH v7 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-26 22:44 ` [PATCH v7 1/3] docs: " Ninad Palsule
2023-03-27 7:47 ` Joel Stanley
2023-03-27 7:52 ` Cédric Le Goater
2023-03-27 14:48 ` Ninad Palsule
2023-03-27 15:10 ` Cédric Le Goater
2023-03-27 15:28 ` Ninad Palsule
2023-03-27 13:04 ` Ninad Palsule
2023-03-26 22:44 ` [PATCH v7 2/3] tpm: Extend common APIs to support TPM TIS I2C Ninad Palsule
2023-03-27 0:14 ` Stefan Berger
2023-03-26 22:44 ` [PATCH v7 3/3] tpm: Add support for TPM device over I2C bus Ninad Palsule
2023-03-27 13:40 ` Stefan Berger
2023-03-27 15:54 ` Ninad Palsule
2023-03-27 1:05 ` [PATCH v7 0/3] Add support for TPM devices " Joel Stanley
2023-03-27 3:52 ` Ninad Palsule
2023-03-27 8:04 ` Joel Stanley
2023-03-27 8:20 ` Cédric Le Goater
2023-03-27 10:49 ` Joel Stanley
2023-03-27 11:17 ` Stefan Berger
2023-03-27 11:11 ` Stefan Berger
2023-03-27 11:18 ` Joel Stanley
2023-03-27 11:24 ` Stefan Berger [this message]
2023-03-27 12:31 ` Stefan Berger
2023-03-27 13:09 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=633a1c3a-6dd8-4f20-6194-a866fd9c3b7c@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).