qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
	qemu-devel@nongnu.org, Chrysostomos Nanakos <chris@include.gr>
Subject: Re: [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile
Date: Wed, 8 Mar 2017 13:33:06 -0600	[thread overview]
Message-ID: <63437c2c-239e-a0af-d02e-c2993018ea93@redhat.com> (raw)
In-Reply-To: <20170308184610.GE5211@noname.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On 03/08/2017 12:46 PM, Kevin Wolf wrote:
>>> Oh, I meant to add:
>>>
>>> Should probably mention that it was commit da34e65 that introduced the
>>> problem (if I'm right?).  Does that mean we have not been compiling
>>> archipelago.c since Mar 2016?
>>
>> At least here on my machine it does indeed compile before that commit
>> and fails afterwards. So, yes, maybe we actually have not. :-)
> 
> In that case, maybe we should rather remove the driver because very
> obviously nobody is interested in it, not even the maintainer. Keeping
> things around that nobody tests (and consequently, nobody uses) is just
> a useless maintenance burden.

We've released 2.6, 2.7, and 2.8 with no complaints about failure to
compile. Sounds like a good candidate for removal in 2.9.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-03-08 19:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 18:18 [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile Max Reitz
2017-03-08 18:25 ` Eric Blake
2017-03-08 18:27   ` Max Reitz
2017-03-08 18:28   ` Eric Blake
2017-03-08 18:32     ` Max Reitz
2017-03-08 18:46       ` Kevin Wolf
2017-03-08 19:33         ` Eric Blake [this message]
2017-03-08 18:38   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63437c2c-239e-a0af-d02e-c2993018ea93@redhat.com \
    --to=eblake@redhat.com \
    --cc=chris@include.gr \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).