[Qemu-devel] [PATCH v3] trivial fix of malloc to g_new in thunk

[Qemu-devel] [PATCH v3] trivial fix of malloc to g_new in thunk

[Aarushi Mehta]

Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>

Note that since thunking occurs throughout the lifetime of the QEMU
instance, there is no matching 'free' to correct.

---
 thunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thunk.c b/thunk.c
index d5d8645cd4..17f3d320bb 100644
--- a/thunk.c
+++ b/thunk.c
@@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name,
const argtype *types)
     for(i = 0;i < 2; i++) {
         offset = 0;
         max_align = 1;
-        se->field_offsets[i] = malloc(nb_fields * sizeof(int));
+        se->field_offsets[i] = g_new(int, nb_fields);
         type_ptr = se->field_types;
         for(j = 0;j < nb_fields; j++) {
             size = thunk_type_size(type_ptr, i);
-- 
2.17.1
Regards
Aarushi Mehta

Re: [Qemu-devel] [PATCH v3] trivial fix of malloc to g_new in thunk

[Philippe Mathieu-Daudé]

On 2/28/19 5:46 PM, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Note that since thunking occurs throughout the lifetime of the QEMU
> instance, there is no matching 'free' to correct.
> 
> ---
>  thunk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/thunk.c b/thunk.c
> index d5d8645cd4..17f3d320bb 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -89,7 +89,7 @@ void thunk_register_struct(int id, const char *name,
> const argtype *types)

Clearer than using a single:

       se->field_offsets = g_new(int *, nb_fields * 2);

So:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>      for(i = 0;i < 2; i++) {

BTW we can replace here by:

       for (i = 0; i < ARRAY_SIZE(se->field_offsets); i++) {

>          offset = 0;
>          max_align = 1;
> -        se->field_offsets[i] = malloc(nb_fields * sizeof(int));
> +        se->field_offsets[i] = g_new(int, nb_fields);
>          type_ptr = se->field_types;
>          for(j = 0;j < nb_fields; j++) {
>              size = thunk_type_size(type_ptr, i);
> 

Re: [Qemu-devel] [PATCH v3] trivial fix of malloc to g_new in thunk

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

On Thu, Feb 28, 2019 at 10:16:57PM +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> Note that since thunking occurs throughout the lifetime of the QEMU
> instance, there is no matching 'free' to correct.
> 
> ---

Hi Aarushi,
The following formatting is commonly used:

  Subject: [PATCH v3] thunk: fix of malloc to g_new

  Note that since thunking occurs throughout the lifetime of the QEMU
  instance, there is no matching 'free' to correct.

  Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
  Reviewed-by: Eric Blake <eblake@redhat.com>

I changed the subject to include the prefix of the component being
modified.  You can look up the preferred prefix using "git log thunk.c"
to see what other commits have used.

The Signed-off-by: goes at the bottom of the commit description.

Don't worry if it takes a few tries to get the formatting conventions.
There is scripts/checkpatch.pl for scanning patches for coding style
violations but I think it wouldn't have detected these things.

The code change itself looks good:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]