qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: aidan_leuck@selinc.com, qemu-devel@nongnu.org
Cc: kkostiuk@redhat.com
Subject: Re: [PATCH v5 1/2] Refactor common functions between POSIX and Windows implementation
Date: Thu, 28 Mar 2024 18:43:41 +0100	[thread overview]
Message-ID: <63600417-9187-4d0b-8bcc-db7e965ff008@linaro.org> (raw)
In-Reply-To: <20240328154049.3090753-2-aidan_leuck@selinc.com>

On 28/3/24 16:40, aidan_leuck@selinc.com wrote:
> From: aidaleuc <aidan_leuck@selinc.com>
> 
> Signed-off-by: aidaleuc <aidan_leuck@selinc.com>
> ---
>   qga/commands-common-ssh.c | 50 ++++++++++++++++++++++++++++++++++++++
>   qga/commands-common-ssh.h | 10 ++++++++
>   qga/commands-posix-ssh.c  | 51 +++------------------------------------
>   qga/meson.build           |  1 +
>   4 files changed, 64 insertions(+), 48 deletions(-)
>   create mode 100644 qga/commands-common-ssh.c
>   create mode 100644 qga/commands-common-ssh.h


> diff --git a/qga/commands-posix-ssh.c b/qga/commands-posix-ssh.c
> index 236f80de44..c82ccfe629 100644
> --- a/qga/commands-posix-ssh.c
> +++ b/qga/commands-posix-ssh.c
> @@ -9,12 +9,13 @@
>   #include <locale.h>
>   #include <pwd.h>
>   
> +#include "commands-common-ssh.h"
>   #include "qapi/error.h"
>   #include "qga-qapi-commands.h"
>   
>   #ifdef QGA_BUILD_UNIT_TEST
> -static struct passwd *
> -test_get_passwd_entry(const gchar *user_name, GError **error)
> + static struct passwd *
> + test_get_passwd_entry(const gchar *user_name, GError **error)

Modulo this spurious change,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thank you for your various iterations,

Phil.


  reply	other threads:[~2024-03-28 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 15:40 [PATCH v5 0/2] Implement SSH commands in QEMU GA for Windows aidan_leuck
2024-03-28 15:40 ` [PATCH v5 1/2] Refactor common functions between POSIX and Windows implementation aidan_leuck
2024-03-28 17:43   ` Philippe Mathieu-Daudé [this message]
2024-03-28 15:40 ` [PATCH v5 2/2] Implement SSH commands in QEMU GA for Windows aidan_leuck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63600417-9187-4d0b-8bcc-db7e965ff008@linaro.org \
    --to=philmd@linaro.org \
    --cc=aidan_leuck@selinc.com \
    --cc=kkostiuk@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).