From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyGuB-0007IY-74 for qemu-devel@nongnu.org; Mon, 06 Aug 2012 02:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyGu9-00053q-Ov for qemu-devel@nongnu.org; Mon, 06 Aug 2012 02:35:07 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:46211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyGu9-00050a-Hg for qemu-devel@nongnu.org; Mon, 06 Aug 2012 02:35:05 -0400 Date: Mon, 6 Aug 2012 02:35:03 -0400 (EDT) From: Amos Kong Message-ID: <637142518.186598.1344234903791.JavaMail.root@redhat.com> In-Reply-To: <20120802103146.17d732e9@doriath.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 00/27]: add new error format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, eblake@redhat.com ----- Original Message ----- > On Thu, 02 Aug 2012 10:31:28 +0800 > Amos Kong wrote: > > > On 01/08/12 21:29, Luiz Capitulino wrote: > > > On Wed, 01 Aug 2012 19:33:27 +0800 > > > Amos Kong wrote: > > > > > >> On 31/07/12 22:44, Luiz Capitulino wrote: > > >>> On Fri, 27 Jul 2012 18:31:41 -0300 > > >>> Luiz Capitulino wrote: > > >>> > > >>>> [Please, read below why this is an RFC] > > >>>> > > >>>> This series implements the 'Plan for error handling in QMP' as > > >>>> described > > >>>> by Anthony in this email: > > >> > > >> > > >> > > >> Tested with > > >> http://repo.or.cz/w/qemu/qmp-unstable.git/shortlog/refs/heads/error/new-format/v1 > > > > > > Thanks for testing Amos, but that branch is where I'm working > > > currently so > > > the code there is constantly changing. It's better to wait until > > > I post it > > > to the list. > > > > Got it. > > > > > Could you share your test-case, btw? > > > > 1. start a migration listen vm > > x86_64-softmmu/qemu-system-x86_64 -monitor stdio -boot n -vnc :2 > > -incoming tcp:0:1234 > > > > 2. start a migration client vm > > x86_64-softmmu/qemu-system-x86_64 --enable-kvm -monitor stdio -boot > > n > > -vnc :1 > > > > 3. execute migration > > vm2 (qemu) migrate -d tcp:0:1234 > > vm2 (qemu) info migration > > > > expected result: migration should complete successfully > > This should work fine with v1 I posted yesterday. > > Actually, master is buggy: > > (qemu) migrate -d tcp:0:4444 > migrate: Connection can not be completed immediately I thought it's a note of real socket status, not an error message. > (qemu) > > I wonder how you did not get this on your test-case? > Anyway, this is also fixed in v1. Thanks.