From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Drew DeVault <sir@cmpwn.com>, Laurent Vivier <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v3] linux-user: implement execveat
Date: Fri, 4 Nov 2022 11:01:16 +0100 [thread overview]
Message-ID: <63718a3c-e8f5-579b-3d23-41b0d992ea19@linaro.org> (raw)
In-Reply-To: <CO3F6B8K38DE.1OTGB55K8CMB2@taiga>
On 4/11/22 10:55, Drew DeVault wrote:
> On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote:
>> Splitting this big patch would ease review:
>
> It's only +165/-131, are you sure it really needs to be split?
I tend to ignore patches over 120 lines of change :)
In this case it is about execve(), so critical enough to have me
spend the time to figure out your changes and decompose them.
Think about someone looking at your patch in months and not having
to do that decomposition again.
Anyway, it is up to the maintainer who will merge your patch ;)
>> 1/ Replace safe_execve() by safe_execveat()
>>
>> -safe_execve(exec_path, argp, envp))
>> +safe_execveat(AT_FDCWD, exec_path, argp, envp, 0));
>>
>> 2/ Extract do_execve()
>>
>> 3/ Convert do_execve() to do_execveat() adding dirfd/flags args
>>
>> 4/ Add TARGET_NR_execveat case
next prev parent reply other threads:[~2022-11-04 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:32 [PATCH v3] linux-user: implement execveat Drew DeVault
2022-11-03 19:54 ` Helge Deller
2022-11-04 9:53 ` Philippe Mathieu-Daudé
2022-11-04 9:55 ` Drew DeVault
2022-11-04 10:01 ` Philippe Mathieu-Daudé [this message]
2022-11-04 10:03 ` Laurent Vivier
2022-11-04 10:16 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63718a3c-e8f5-579b-3d23-41b0d992ea19@linaro.org \
--to=philmd@linaro.org \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).