From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87B37C47097 for ; Thu, 3 Jun 2021 16:54:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5368D61026 for ; Thu, 3 Jun 2021 16:54:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5368D61026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loqbn-0002dJ-Bu for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 12:54:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loqM3-0006Er-9e for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:37:59 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:43653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loqM1-0006Fd-OS for qemu-devel@nongnu.org; Thu, 03 Jun 2021 12:37:59 -0400 Received: by mail-pj1-x1030.google.com with SMTP id l10-20020a17090a150ab0290162974722f2so4221487pja.2 for ; Thu, 03 Jun 2021 09:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=skFqzzu43yKiHGPWqLzS2TIi1Y0w+zX5/VlAyY+6EXc=; b=BCmy/++QjU9JhQM0SDIOVEuoW8XAFZ0fq8/7V6Kih7rrj/0X24kLlnwpp6d61mUQ89 bypxpHQKRPKWo29lzMlinBgvjR5Q1t6D0bBwO/oJ/6oLgBtejgZlMEIY+uRaHbje+ioD XPsTtafrxZ7+dsdCr/abcnEy9njdgOXnBX07er7iAUCTWTv0XyThODCjePulIY+mVkU7 lyzaoE4KWP6M45nDIZEpV+fGQQs+rOg29WORN7/Dx2tDFLle8Aev2CYfG5Tq33ffNgnc bROnxm+SfDNWKer85Ko6rc11ZffkLAPyXOdPBx7Gs4MIb2XjIRJKOEiwkIOX/p7QfP4/ f3aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=skFqzzu43yKiHGPWqLzS2TIi1Y0w+zX5/VlAyY+6EXc=; b=Oh0FiHzkPrvuneY5qyvX1bWVlrg7hXFmt9kWvmjWIdQ6ptqRq72TFMOOa6/oQWV2Dg UNhf5+XkXHBdFNAJzgWsh4WdkumQ7CkTbeU5fnNnyV1YFRsNc2jMxGDFQYpHazdHvkK9 UEoxts++cF6u0sSbj8oqocoyjlWkH2CUanoT1eTxhTltatiYd3+Bo0aHlvYeT1e+nNYj m8xUKQnxV0VSwsnxnpJ6wzM4EfqX3nGc8W++wBu8CburvHdV3u9O72ksYhlfoe+gP4Fl CQchLdvYsdMeO57BUdFKgpJxCBXJGzDxiYTP+xbApziPovRlapoMOnNjounKce8AnqjI asPQ== X-Gm-Message-State: AOAM531smmsCT2kmjQ7RBgr+8IpRmzSzL3DQBRlhOnYnWq6E7JlILYwy 77QgUEQcFpKlI5k+DdtEXedtKQ== X-Google-Smtp-Source: ABdhPJwq3B0Iu+uaelrt65SbJzqOxsvl+Wn/TZgGxG+ZhKDUKpKruu5lwcoh8eOSSKYbOdfqeWysAw== X-Received: by 2002:a17:90a:bd82:: with SMTP id z2mr72646pjr.87.1622738276245; Thu, 03 Jun 2021 09:37:56 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id x13sm3153420pja.3.2021.06.03.09.37.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 09:37:55 -0700 (PDT) Subject: Re: [PATCH 5/6] target/microblaze: Replace magic values by proper definitions To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210603090310.2749892-1-f4bug@amsat.org> <20210603090310.2749892-6-f4bug@amsat.org> From: Richard Henderson Message-ID: <6381fbde-6033-10b3-6ff9-759536e5e0e3@linaro.org> Date: Thu, 3 Jun 2021 09:37:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210603090310.2749892-6-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.603, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E. Iglesias" , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/3/21 2:03 AM, Philippe Mathieu-Daudé wrote: > + if (access_type == MMU_INST_FETCH) { > + env->esr |= ESR_EC_INSN_STORAGE; > + } else { > + env->esr |= ESR_EC_DATA_STORAGE; > + } indentation is off. r~