From: Thomas Huth <thuth@redhat.com>
To: Nir Lichtman <nir@lichtman.org>,
qemu-devel@nongnu.org, kraxel@redhat.com
Cc: peter.maydell@linaro.org, marcandre.lureau@redhat.com
Subject: Re: [PATCH] ui/sdl2: fix reset scaling binding to be consistent with gtk
Date: Fri, 19 Sep 2025 08:33:26 +0200 [thread overview]
Message-ID: <639603b9-6fa7-4316-a7c9-50fb29bdeb99@redhat.com> (raw)
In-Reply-To: <20250910114929.GA1783677@lichtman.org>
On 10/09/2025 13.49, Nir Lichtman wrote:
> Problem: Currently the reset scaling hotkey is inconsistent between SDL
> and GTK graphics modes.
>
> Solution: Fix SDL to use MOD+0 instead of MOD+u which is in line with
> GTK and generally more consistent with other apps.
>
> This is also related to my previously sent patch fixing the docs.
>
> Suggested-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Nir Lichtman <nir@lichtman.org>
> ---
> ui/sdl2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index b00e421..032dc14 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -421,7 +421,7 @@ static void handle_keydown(SDL_Event *ev)
> sdl_grab_end(scon);
> }
> break;
> - case SDL_SCANCODE_U:
> + case SDL_SCANCODE_0:
> sdl2_window_resize(scon);
> if (!scon->opengl) {
> /* re-create scon->texture */
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2025-09-19 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 11:49 [PATCH] ui/sdl2: fix reset scaling binding to be consistent with gtk Nir Lichtman
2025-09-19 6:33 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639603b9-6fa7-4316-a7c9-50fb29bdeb99@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=nir@lichtman.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).