From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Joel Stanley" <joel@jms.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message
Date: Thu, 6 Jul 2023 10:55:11 +0200 [thread overview]
Message-ID: <639f7aa6-37c6-7680-dfd6-3c2d7cc35329@linaro.org> (raw)
In-Reply-To: <20230706024528.40065-1-joel@jms.id.au>
On 6/7/23 04:45, Joel Stanley wrote:
> Add the function name so there's an indication as to where the message
> is coming from. Change all prints to use the offset instead of the
> address.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Happy to use the address instead of the offset (or print both), but I
> like the idea of being consistent.
> ---
> hw/ppc/pnv_core.c | 34 ++++++++++++++++++----------------
> 1 file changed, 18 insertions(+), 16 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-06 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 2:45 [PATCH] ppc/pnv: Log all unimp warnings with similar message Joel Stanley
2023-07-06 6:22 ` Cédric Le Goater
2023-07-06 8:55 ` Philippe Mathieu-Daudé [this message]
2023-07-07 7:19 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639f7aa6-37c6-7680-dfd6-3c2d7cc35329@linaro.org \
--to=philmd@linaro.org \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).