From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Denis Plotnikov <dplotnikov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, berto@igalia.com,
qemu-block@nongnu.org, armbru@redhat.com, den@openvz.org
Subject: Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test
Date: Tue, 28 Apr 2020 08:01:20 -0500 [thread overview]
Message-ID: <639fc953-3e01-6ff8-460e-5f571ffca48f@redhat.com> (raw)
In-Reply-To: <f96f8020-2c39-3676-3bff-d35038f6e3df@redhat.com>
On 4/28/20 7:55 AM, Max Reitz wrote:
>>>> +# This tests qocw2-specific low-level functionality
>>>> +_supported_fmt qcow2
>>>> +_supported_proto file
>>>> +_supported_os Linux
>>> This test doesn’t work with compat=0.10 (because we can’t store a
>>> non-default compression type there) or data_file (because those don’t
>>> support compression), so those options should be marked as unsupported.
>>>
>>> (It does seem to work with any refcount_bits, though.)
>>
>> Could I ask how to achieve that?
>> I can't find any _supported_* related.
>
>
> It’s _unsupported_imgopts.
Test 036 is an example of this.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-28 13:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:11 [PATCH v20 0/4] qcow2: Implement zstd cluster compression methodi Denis Plotnikov
2020-04-21 8:11 ` [PATCH v20 1/4] qcow2: introduce compression type feature Denis Plotnikov
2020-04-21 10:40 ` Alberto Garcia
2020-04-27 12:35 ` Max Reitz
2020-04-21 8:11 ` [PATCH v20 2/4] qcow2: rework the cluster compression routine Denis Plotnikov
2020-04-27 12:36 ` Max Reitz
2020-04-21 8:11 ` [PATCH v20 3/4] qcow2: add zstd cluster compression Denis Plotnikov
2020-04-27 12:35 ` Max Reitz
2020-04-27 19:26 ` Denis Plotnikov
2020-04-28 6:16 ` Max Reitz
2020-04-28 7:23 ` Denis Plotnikov
2020-04-28 10:17 ` Max Reitz
2020-04-21 8:11 ` [PATCH v20 4/4] iotests: 287: add qcow2 compression type test Denis Plotnikov
2020-04-21 12:06 ` Vladimir Sementsov-Ogievskiy
2020-04-27 13:29 ` Max Reitz
2020-04-28 11:41 ` Denis Plotnikov
2020-04-28 12:55 ` Max Reitz
2020-04-28 13:01 ` Eric Blake [this message]
2020-04-28 13:34 ` Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639fc953-3e01-6ff8-460e-5f571ffca48f@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=dplotnikov@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).