From: Ani Sinha <anisinha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Akihiko Odaki <akihiko.odaki@daynix.com>,
qemu-devel <qemu-devel@nongnu.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Julia Suvorova <jusual@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v6 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port
Date: Mon, 3 Jul 2023 11:38:47 +0530 [thread overview]
Message-ID: <63B46F8F-A52C-4BFC-BAFD-06ACAF2AA6E1@redhat.com> (raw)
In-Reply-To: <20230702005916-mutt-send-email-mst@kernel.org>
> On 02-Jul-2023, at 10:29 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Sat, Jul 01, 2023 at 04:09:31PM +0900, Akihiko Odaki wrote:
>> Yes, I want the slot number restriction to be enforced. If it worries you
>> too much for regressions, you may implement it as a warning first and then
>> turn it a hard error when the next development phase starts.
>
> That's not a bad idea.
If we had not enforced the check strongly, the tests that we fixed would not get noticed.
next prev parent reply other threads:[~2023-07-03 6:09 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 4:07 [PATCH v6 0/5] test and QEMU fixes to ensure proper PCIE device usage Ani Sinha
2023-06-29 4:07 ` [PATCH v6 1/5] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-06-29 4:07 ` [PATCH v6 2/5] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port Ani Sinha
2023-06-29 4:07 ` [PATCH v6 3/5] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-06-29 4:07 ` [PATCH v6 4/5] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test Ani Sinha
2023-06-29 7:03 ` Thomas Huth
2023-06-30 9:09 ` Igor Mammedov
2023-06-29 4:07 ` [PATCH v6 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port Ani Sinha
2023-06-29 6:47 ` Akihiko Odaki
2023-06-29 8:05 ` Ani Sinha
2023-06-29 8:49 ` Akihiko Odaki
2023-06-29 14:18 ` Ani Sinha
2023-06-30 2:43 ` Akihiko Odaki
2023-06-30 6:02 ` Michael S. Tsirkin
2023-06-30 7:41 ` Ani Sinha
2023-06-30 8:32 ` Michael S. Tsirkin
2023-06-30 8:36 ` Ani Sinha
2023-06-30 8:43 ` Michael S. Tsirkin
2023-06-30 9:22 ` Ani Sinha
2023-06-30 10:00 ` Michael S. Tsirkin
2023-06-30 10:37 ` Ani Sinha
2023-06-30 10:40 ` Michael S. Tsirkin
2023-06-30 10:45 ` Ani Sinha
2023-06-30 10:49 ` Ani Sinha
2023-06-30 11:36 ` Akihiko Odaki
2023-06-30 11:47 ` Ani Sinha
2023-06-30 11:55 ` Akihiko Odaki
2023-06-30 13:56 ` Ani Sinha
2023-07-01 7:09 ` Akihiko Odaki
2023-07-02 4:59 ` Michael S. Tsirkin
2023-07-03 6:08 ` Ani Sinha [this message]
2023-07-04 5:01 ` Akihiko Odaki
2023-07-04 5:39 ` Ani Sinha
2023-07-04 10:33 ` Ani Sinha
2023-07-04 10:36 ` Michael S. Tsirkin
2023-07-04 11:10 ` Ani Sinha
2023-07-03 13:31 ` Ani Sinha
2023-06-30 15:29 ` Michael S. Tsirkin
2023-07-01 7:28 ` Akihiko Odaki
2023-07-04 11:38 ` Igor Mammedov
2023-07-04 11:50 ` Akihiko Odaki
2023-07-04 12:36 ` Igor Mammedov
2023-07-04 12:51 ` Akihiko Odaki
2023-07-04 14:03 ` Ani Sinha
2023-07-05 2:30 ` Akihiko Odaki
2023-06-30 10:25 ` Michael S. Tsirkin
2023-06-29 14:24 ` Michael S. Tsirkin
2023-06-29 14:37 ` Ani Sinha
2023-06-29 15:32 ` Michael S. Tsirkin
2023-06-29 15:57 ` Ani Sinha
2023-06-29 16:45 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63B46F8F-A52C-4BFC-BAFD-06ACAF2AA6E1@redhat.com \
--to=anisinha@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).