Re: [Qemu-devel] [PATCH] vl.c: make current_machine as non-global variable

[Thomas Huth <thuth@redhat.com>]

On 02/04/2019 07.55, Like Xu wrote:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
> 
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
> ---
[...]
> --- a/vl.c
> +++ b/vl.c
> @@ -1265,6 +1265,8 @@ static QemuOptsList qemu_smp_opts = {
>      },
>  };
>  
> +MachineState *current_machine;

To be sure that it is only used here, could you please also make the
variable "static"?

 Thanks,
  Thomas


> +
>  static void smp_parse(QemuOpts *opts)
>  {
>      if (opts) {
> @@ -1462,8 +1464,6 @@ static int usb_parse(const char *cmdline)
>  /***********************************************************/
>  /* machine registration */
>  
> -MachineState *current_machine;
> -
>  static MachineClass *find_machine(const char *name)
>  {
>      GSList *el, *machines = object_class_get_list(TYPE_MACHINE, false);
>