Re: [PATCH v4 11/12] hw/ppc/pegasos2: Add Pegasos I emulation

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 23/10/25 02:06, BALATON Zoltan wrote:
> The Pegasos II is a redesign of the original Pegasos (later marked I)
> that replaces the north bridge and has updated firmware but otherwise
> these are very similar. The Pegasos uses the same north bridge that
> AmigaOne used which we already emulate so we can also easily emulate
> Pegasos I.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/pegasos2.c | 156 ++++++++++++++++++++++++++++++++++------------
>   1 file changed, 117 insertions(+), 39 deletions(-)


> @@ -89,6 +96,8 @@ static void pegasos2_cpu_reset(void *opaque)
>       if (pm->vof) {
>           cpu->env.gpr[1] = 2 * VOF_STACK_SIZE - 0x20;
>           cpu->env.nip = 0x100;
> +    } else if (pm->type == PEGASOS1) {
> +        cpu->env.nip = 0xfffc0100;

Preferably add a comment explaining/describing this value (think
at your future you in 3 years ;) ).


> +    case PEGASOS1:
> +    {
> +        MemoryRegion *pci_mem, *mr;
> +
> +        /* Articia S */
> +        pm->nb = DEVICE(sysbus_create_simple(TYPE_ARTICIA, 0xfe000000, NULL));
> +        pci_mem = sysbus_mmio_get_region(SYS_BUS_DEVICE(pm->nb), 1);
> +        mr = g_new(MemoryRegion, 1);
> +        memory_region_init_alias(mr, OBJECT(pm->nb), "pci-mem-low", pci_mem,
> +                                 0, 0x1000000);
> +        memory_region_add_subregion(get_system_memory(), 0xfd000000, mr);
> +        mr = g_new(MemoryRegion, 1);
> +        memory_region_init_alias(mr, OBJECT(pm->nb), "pci-mem-high", pci_mem,
> +                                 0x80000000, 0x7d000000);
> +        memory_region_add_subregion(get_system_memory(), 0x80000000, mr);

Since I don't want to delay this series any further, as a future
cleanup consider passing the host MR (get_system_memory) as a link
property, and map PCI hi/lo regions in the host bridge realize.

> +        pci_bus = PCI_BUS(qdev_get_child_bus(pm->nb, "pci.0"));
> +        break;
> +    }

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>