From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Eric Blake <eblake@redhat.com>, Jeff Cody <jcody@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 02/11] blockjob: Update description of the 'id' field
Date: Sat, 2 Jul 2016 15:47:35 +0200 [thread overview]
Message-ID: <63c31aa5-c448-311f-84c3-c00343700432@redhat.com> (raw)
In-Reply-To: <330e110a04ea4e3c8b202d5db0bf82223e03dc18.1467386530.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On 01.07.2016 17:52, Alberto Garcia wrote:
> The 'id' field of the BlockJob structure will be able to hold any ID,
> not only a device name. This patch updates the description of that
> field and the error messages where it is being used.
>
> Soon we'll add the ability to set an arbitrary ID when creating a
> block job.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block/mirror.c | 3 ++-
> blockjob.c | 3 ++-
> include/block/blockjob.h | 5 +----
> include/qapi/qmp/qerror.h | 3 ---
> 4 files changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
next prev parent reply other threads:[~2016-07-02 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 15:51 [Qemu-devel] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID Alberto Garcia
2016-07-01 15:51 ` [Qemu-devel] [PATCH v3 01/11] stream: Fix prototype of stream_start() Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 02/11] blockjob: Update description of the 'id' field Alberto Garcia
2016-07-02 13:47 ` Max Reitz [this message]
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 03/11] blockjob: Add block_job_get() Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job() Alberto Garcia
2016-07-02 14:02 ` Max Reitz
2016-07-04 13:23 ` Kevin Wolf
2016-07-04 14:05 ` Daniel P. Berrange
2016-07-04 13:35 ` Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create() Alberto Garcia
2016-07-02 14:09 ` Max Reitz
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror' Alberto Garcia
2016-07-02 14:30 ` Max Reitz
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 07/11] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 08/11] stream: Add 'job-id' parameter to 'block-stream' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 09/11] commit: Add 'job-id' parameter to 'block-commit' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 10/11] qemu-img: Set the ID of the block job in img_commit() Alberto Garcia
2016-07-02 14:21 ` Max Reitz
2016-07-04 12:43 ` Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 11/11] blockjob: Update description of the 'device' field in the QMP API Alberto Garcia
2016-07-02 14:37 ` Max Reitz
2016-07-04 15:49 ` [Qemu-devel] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c31aa5-c448-311f-84c3-c00343700432@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).