From: Rorie Reyes <rreyes@linux.ibm.com>
To: Anthony Krowiak <akrowiak@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com,
jjherne@linux.ibm.com, borntraeger@linux.ibm.com,
alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com
Subject: Re: [RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change
Date: Fri, 23 May 2025 09:39:07 -0400 [thread overview]
Message-ID: <63ce16e5-b318-4eff-b757-68a3dbd7dd9f@linux.ibm.com> (raw)
In-Reply-To: <f743c32c-439d-483b-b4db-78e6871fdb35@linux.ibm.com>
>> diff --git a/hw/s390x/ap-stub.c b/hw/s390x/ap-stub.c
>> new file mode 100644
>> index 0000000000..e2dacff959
>> --- /dev/null
>> +++ b/hw/s390x/ap-stub.c
>> @@ -0,0 +1,25 @@
>> +/*
>> + * VFIO based AP matrix device assignment
>> + *
>> + * Copyright 2025 IBM Corp.
>> + * Author(s): Rorie Reyes <rreyes@linux.ibm.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0-or-later
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2
>> or (at
>> + * your option) any later version. See the COPYING file in the
>> top-level
>> + * directory.
>> + */
>> +
>> +#include "qemu/osdep.h"
>> +#include "hw/s390x/ap-bridge.h"
>> +
>> +int ap_chsc_sei_nt0_get_event(void *res)
>> +{
>> + return 0;
>> +}
>> +
>> +int ap_chsc_sei_nt0_have_event(void)
>> +{
>> + return 0;
>> +}
>
> Shouldn't these stub function signatures match those in
> ap-bridge.h?
>
I'll update 'ap_chsc_sei_nt0_have_event' to be a boolean function, but
keep the get_event as an int. The definition that I'll use from the
header file will keep the integrity of function type
prev parent reply other threads:[~2025-05-23 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 4:47 [RFC PATCH v10 0/4] Report vfio-ap configuration changes Rorie Reyes
2025-05-23 4:47 ` [RFC PATCH v10 1/4] hw/vfio/ap: notification handler for AP config changed event Rorie Reyes
2025-05-23 4:47 ` [RFC PATCH v10 2/4] hw/vfio/ap: store object indicating AP config changed in a queue Rorie Reyes
2025-05-23 4:47 ` [RFC PATCH v10 3/4] hw/vfio/ap: Storing event information for an AP configuration change event Rorie Reyes
2025-05-23 13:00 ` Anthony Krowiak
2025-05-23 13:37 ` Rorie Reyes
2025-05-23 4:47 ` [RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change Rorie Reyes
2025-05-23 13:04 ` Anthony Krowiak
2025-05-23 13:39 ` Rorie Reyes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ce16e5-b318-4eff-b757-68a3dbd7dd9f@linux.ibm.com \
--to=rreyes@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).