qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-ppc@nongnu.org
Subject: Re: [PATCH-for-9.1 12/12] exec/poison: Poison CONFIG_SOFTMMU again
Date: Fri, 15 Mar 2024 11:32:00 -1000	[thread overview]
Message-ID: <63cf3b97-1637-40e7-9956-461b215f944f@linaro.org> (raw)
In-Reply-To: <20240313213339.82071-13-philmd@linaro.org>

On 3/13/24 11:33, Philippe Mathieu-Daudé wrote:
> Now that the confusion around SOFTMMU vs SYSTEM emulation
> was clarified, we can restore the CONFIG_SOFTMMU poison
> pragma.
> 
> This reverts commit d31b84041d4353ef310ffde23c87b78c2aa32ead
> ("exec/poison: Do not poison CONFIG_SOFTMMU").
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/poison.h         | 1 +
>   scripts/make-config-poison.sh | 1 -
>   2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/exec/poison.h b/include/exec/poison.h
> index 1ea5633eb3..fbec710f6c 100644
> --- a/include/exec/poison.h
> +++ b/include/exec/poison.h
> @@ -84,6 +84,7 @@
>   #pragma GCC poison CONFIG_HVF
>   #pragma GCC poison CONFIG_LINUX_USER
>   #pragma GCC poison CONFIG_KVM
> +#pragma GCC poison CONFIG_SOFTMMU
>   #pragma GCC poison CONFIG_WHPX
>   #pragma GCC poison CONFIG_XEN
>   
> diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
> index 2b36907e23..6ef5580f84 100755
> --- a/scripts/make-config-poison.sh
> +++ b/scripts/make-config-poison.sh
> @@ -9,7 +9,6 @@ fi
>   exec sed -n \
>     -e' /CONFIG_TCG/d' \
>     -e '/CONFIG_USER_ONLY/d' \
> -  -e '/CONFIG_SOFTMMU/d' \
>     -e '/^#define / {' \
>     -e    's///' \
>     -e    's/ .*//' \

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2024-03-15 21:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 21:33 [PATCH-for-9.1 00/12] accel/tcg: Finish replacing SOFTMMU -> SYSTEM Philippe Mathieu-Daudé
2024-03-13 21:33 ` [PATCH-for-9.0? 01/12] accel/tcg/plugin: Remove CONFIG_SOFTMMU_GATE definition Philippe Mathieu-Daudé
2024-03-14  7:16   ` Thomas Huth
2024-03-15  6:42   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.0? 02/12] travis-ci: Rename SOFTMMU -> SYSTEM Philippe Mathieu-Daudé
2024-03-14  7:18   ` Thomas Huth
2024-03-15  6:42   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.0? 03/12] gdbstub: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2024-03-15 21:13   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.0? 04/12] gdbstub/system: Rename 'user_ctx' argument as 'ctx' Philippe Mathieu-Daudé
2024-03-15 21:14   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.0? 05/12] target/ppc: Rename init_excp_4xx_softmmu() -> init_excp_4xx() Philippe Mathieu-Daudé
2024-03-14  4:24   ` Nicholas Piggin
2024-03-13 21:33 ` [PATCH-for-9.1 06/12] tcg/sparc64: Check for USER_ONLY definition instead of SOFTMMU one Philippe Mathieu-Daudé
2024-03-15 21:17   ` Richard Henderson
2024-03-15 21:31   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.1 07/12] plugins/api: " Philippe Mathieu-Daudé
2024-03-15 21:19   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.0? 08/12] accel/tcg/tb-maint: Add comments around system emulation Philippe Mathieu-Daudé
2024-03-13 21:33 ` [PATCH-for-9.1 09/12] accel/tcg/internal: Check for USER_ONLY definition instead of SOFTMMU Philippe Mathieu-Daudé
2024-03-15 21:25   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.1 10/12] exec/cpu-defs: Restrict SOFTMMU specific definitions to accel/tcg/ Philippe Mathieu-Daudé
2024-03-15 21:29   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.1 11/12] tcg: Remove unused CONFIG_SOFTMMU definition from libtcg_system.fa Philippe Mathieu-Daudé
2024-03-15 21:31   ` Richard Henderson
2024-03-13 21:33 ` [PATCH-for-9.1 12/12] exec/poison: Poison CONFIG_SOFTMMU again Philippe Mathieu-Daudé
2024-03-15 21:32   ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63cf3b97-1637-40e7-9956-461b215f944f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).