From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ira Weiny <ira.weiny@intel.com>
Cc: Michael Tsirkin <mst@redhat.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Peter Maydell <peter.maydell@linaro.org>, <qemu-devel@nongnu.org>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 1/2] hw/cxl: Fix event log time stamp fields
Date: Thu, 26 Jan 2023 08:34:34 -0800 [thread overview]
Message-ID: <63d2ab9a96dd3_60173294d1@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20230126114130.00000b98@huawei.com>
Jonathan Cameron wrote:
> On Wed, 25 Jan 2023 21:37:27 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
>
> > CXL 3.0 8.2.9.4.2 Set Timestamp and 8.2.9.4.1 Get Timestamp define the
> > way for software to set and get the time stamp of a device. Events
> > should use a time stamp consistent with the Get Timestamp mailbox
> > command.
> >
> > In addition avoid setting the time stamp twice.
> >
> > Fixes: fb64c5661d5f ("hw/cxl/events: Wire up get/clear event mailbox commands")
> > Reported-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> Hi Ira,
>
> I'm going to split this patch as I am carrying a very similar
> utility function for an updated version of the poison list code
> and I'm not sure what order everything will go upstream in.
>
> So I'll split this into:
> 1) Patch that adds cxl_device_get_timestamp() - adding the
> use of this in the GET_TIMESTAMP mailbox command.
>
> 2) Changes pushed down into the patch you mention above.
>
> Given all the code is yours, just split up, I'll keep the SOB.
> Shout if you mind me doing that.
That sounds great. I'm just sorry I did not get to all this sooner.
Thanks!
Ira
next prev parent reply other threads:[~2023-01-26 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 5:37 [PATCH 0/2] hw/cxl: CXL Event processing fixups Ira Weiny
2023-01-26 5:37 ` [PATCH 1/2] hw/cxl: Fix event log time stamp fields Ira Weiny
2023-01-26 11:41 ` Jonathan Cameron via
2023-01-26 16:34 ` Ira Weiny [this message]
2023-01-26 5:37 ` [PATCH 2/2] hw/cxl: Remove check for g_new0() failure Ira Weiny
2023-01-26 11:50 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d2ab9a96dd3_60173294d1@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bwidawsk@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).