qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <eduardo@habkost.net>,
	Richard Henderson <richard.henderson@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 3/3] i386: firmware parsing and sev setup for -bios loaded firmware
Date: Thu, 31 Mar 2022 22:47:35 +0200	[thread overview]
Message-ID: <63d4c9f4-3e7d-e90d-5007-cf665cb88d4c@gmail.com> (raw)
In-Reply-To: <20220331083549.749566-4-kraxel@redhat.com>

On 31/3/22 10:35, Gerd Hoffmann wrote:
> Don't register firmware as rom, not needed (see comment).
> Add x86_firmware_configure() call for proper sev initialization.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Tested-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
>   hw/i386/x86.c | 25 +++++++++++++++++++------
>   1 file changed, 19 insertions(+), 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


  parent reply	other threads:[~2022-03-31 20:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  8:35 [PATCH 0/3] i386: firmware parsing and sev setup for -bios loaded firmware Gerd Hoffmann
2022-03-31  8:35 ` [PATCH 1/3] i386: move bios load error message Gerd Hoffmann
2022-03-31 13:02   ` Daniel P. Berrangé
2022-03-31 20:45   ` Philippe Mathieu-Daudé
2022-03-31  8:35 ` [PATCH 2/3] i386: factor out x86_firmware_configure() Gerd Hoffmann
2022-03-31 13:07   ` Daniel P. Berrangé
2022-03-31 13:27     ` Gerd Hoffmann
2022-03-31 13:33   ` Daniel P. Berrangé
2022-03-31 21:11   ` Philippe Mathieu-Daudé
2022-04-01  5:08     ` Gerd Hoffmann
2022-04-01  5:28       ` Xiaoyao Li
2022-04-01 10:36         ` Philippe Mathieu-Daudé
2022-04-01 15:25           ` Xiaoyao Li
2022-03-31  8:35 ` [PATCH 3/3] i386: firmware parsing and sev setup for -bios loaded firmware Gerd Hoffmann
2022-03-31 13:10   ` Daniel P. Berrangé
2022-03-31 13:44     ` Gerd Hoffmann
2022-03-31 20:47   ` Philippe Mathieu-Daudé [this message]
2022-03-31 20:24 ` [PATCH 0/3] " Michael S. Tsirkin
2022-04-25 13:56   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63d4c9f4-3e7d-e90d-5007-cf665cb88d4c@gmail.com \
    --to=philippe.mathieu.daude@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).