From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Taylor Simpson" <tsimpson@quicinc.com>,
qemu-devel@nongnu.org
Cc: ale@rev.ng, alex.bennee@linaro.org, richard.henderson@linaro.org,
laurent@vivier.eu, bcain@quicinc.com
Subject: Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing
Date: Fri, 22 Jan 2021 12:10:39 -0600 [thread overview]
Message-ID: <63d4f82c-1e1a-7986-9a5b-c0609e430d53@redhat.com> (raw)
In-Reply-To: <4d5081d9-3b7b-4a9c-5007-04f0b5da3f73@amsat.org>
On 1/22/21 11:58 AM, Philippe Mathieu-Daudé wrote:
>> +#include "qemu/osdep.h"
>> +#include "insn.h"
>> +
>> +extern void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,
>> + target_ulong pc);
>> +extern void snprint_a_pkt_debug(GString *buf, Packet *pkt);
>
> No need to declare prototypes in header with 'extern'...
> (also noticed in other patches).
Using the extern on function declarations is not wrong (in fact, some
projects prefer to use extern for everything in a header, regardless of
whether it is function or data, rather than just limiting it to data).
But you do have a point that it's not common practice in qemu, and local
consistency is better than any habits you've picked up in other projects.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-22 18:12 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 3:28 [PATCH v7 00/35] Hexagon patch series Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 01/35] Hexagon Update MAINTAINERS file Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 02/35] Hexagon (target/hexagon) README Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 03/35] Hexagon (include/elf.h) ELF machine definition Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 04/35] Hexagon (target/hexagon) scalar core definition Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 05/35] Hexagon (disas) disassembler Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 06/35] Hexagon (target/hexagon) register names Taylor Simpson
2021-01-22 17:46 ` Philippe Mathieu-Daudé
2021-01-20 3:28 ` [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers Taylor Simpson
2021-01-22 20:30 ` Philippe Mathieu-Daudé
2021-01-22 21:44 ` Philippe Mathieu-Daudé
2021-01-22 21:50 ` Taylor Simpson
2021-01-25 16:16 ` Philippe Mathieu-Daudé
2021-01-20 3:28 ` [PATCH v7 08/35] Hexagon (target/hexagon) GDB Stub Taylor Simpson
2021-01-22 17:48 ` Philippe Mathieu-Daudé
2021-01-20 3:28 ` [PATCH v7 09/35] Hexagon (target/hexagon) architecture types Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 10/35] Hexagon (target/hexagon) instruction and packet types Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 11/35] Hexagon (target/hexagon) register fields Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 12/35] Hexagon (target/hexagon) instruction attributes Taylor Simpson
2021-01-22 17:53 ` Philippe Mathieu-Daudé
2021-01-22 22:01 ` Taylor Simpson
2021-01-25 16:21 ` Philippe Mathieu-Daudé
2021-01-29 23:15 ` Taylor Simpson
2021-02-05 17:35 ` Philippe Mathieu-Daudé
2021-01-20 3:28 ` [PATCH v7 13/35] Hexagon (target/hexagon) instruction/packet decode Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing Taylor Simpson
2021-01-22 17:58 ` Philippe Mathieu-Daudé
2021-01-22 18:10 ` Eric Blake [this message]
2021-01-20 3:28 ` [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions Taylor Simpson
2021-01-22 18:09 ` Philippe Mathieu-Daudé
2021-01-22 21:59 ` Taylor Simpson
2021-01-25 16:29 ` Philippe Mathieu-Daudé
2021-01-25 21:43 ` Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 16/35] Hexagon (target/hexagon/conv_emu.[ch]) " Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 17/35] Hexagon (target/hexagon/fma_emu.[ch]) " Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 18/35] Hexagon (target/hexagon/imported) arch import Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 22/35] Hexagon (target/hexagon) generater phase 4 - " Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 23/35] Hexagon (target/hexagon) opcode data structures Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 24/35] Hexagon (target/hexagon) macros Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 25/35] Hexagon (target/hexagon) instruction classes Taylor Simpson
2021-01-20 3:28 ` [PATCH v7 26/35] Hexagon (target/hexagon) TCG generation Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 28/35] Hexagon (target/hexagon) TCG for floating point instructions Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 29/35] Hexagon (target/hexagon) translation Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 30/35] Hexagon (linux-user/hexagon) Linux user emulation Taylor Simpson
2021-02-17 20:15 ` Laurent Vivier
2021-02-17 21:10 ` Richard Henderson
2021-01-20 3:29 ` [PATCH v7 31/35] Hexagon (tests/tcg/hexagon) TCG tests - multiarch Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 32/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 33/35] Hexagon (tests/tcg/hexagon) TCG tests - floating point Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 34/35] Hexagon build infrastructure Taylor Simpson
2021-01-22 22:34 ` Philippe Mathieu-Daudé
2021-01-22 22:41 ` Philippe Mathieu-Daudé
2021-01-22 22:44 ` Philippe Mathieu-Daudé
2021-01-27 19:16 ` Taylor Simpson
2021-01-20 3:29 ` [PATCH v7 35/35] Add Dockerfile for hexagon Taylor Simpson
2021-01-20 4:13 ` [PATCH v7 00/35] Hexagon patch series no-reply
2021-01-25 22:14 ` Philippe Mathieu-Daudé
2021-01-25 23:09 ` Taylor Simpson
2021-01-25 23:28 ` Brian Cain
2021-03-17 0:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d4f82c-1e1a-7986-9a5b-c0609e430d53@redhat.com \
--to=eblake@redhat.com \
--cc=ale@rev.ng \
--cc=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).