From: Paolo Bonzini <pbonzini@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com
Subject: Re: [PATCH] build-sys: fix -static linking of libvhost-user
Date: Tue, 15 Dec 2020 11:08:40 +0100 [thread overview]
Message-ID: <63dfdf60-1c38-ed53-d555-2b1e0cd25a9a@redhat.com> (raw)
In-Reply-To: <20201215080319.136228-1-marcandre.lureau@redhat.com>
On 15/12/20 09:03, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Fix linking vhost-user binaries with with ./configure -static, by
> overriding glib-2.0 dependency with configure results.
>
> Fixes: 0df750e9d3a5fea5e1 ("libvhost-user: make it a meson subproject")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 9ea05ab49f..7ecd307952 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -268,7 +268,11 @@ endif
> # grandfathered in from the QEMU Makefiles.
> add_project_arguments(config_host['GLIB_CFLAGS'].split(),
> native: false, language: ['c', 'cpp', 'objc'])
> -glib = declare_dependency(link_args: config_host['GLIB_LIBS'].split())
> +glib = declare_dependency(compile_args: config_host['GLIB_CFLAGS'].split(),
> + link_args: config_host['GLIB_LIBS'].split())
> +# override glib dep with the configure results (for subprojects)
> +meson.override_dependency('glib-2.0', glib)
> +
> gio = not_found
> if 'CONFIG_GIO' in config_host
> gio = declare_dependency(compile_args: config_host['GIO_CFLAGS'].split(),
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-12-15 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 8:03 [PATCH] build-sys: fix -static linking of libvhost-user marcandre.lureau
2020-12-15 10:08 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63dfdf60-1c38-ed53-d555-2b1e0cd25a9a@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).