From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B06DC3DA4A for ; Fri, 26 Jul 2024 20:01:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sXR7i-00053T-VN; Fri, 26 Jul 2024 16:01:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXR7h-00052Q-Cl; Fri, 26 Jul 2024 16:01:05 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXR7c-0006DH-Ud; Fri, 26 Jul 2024 16:01:05 -0400 Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46QHRnQh022424; Fri, 26 Jul 2024 20:00:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=O hOFgP28zAeTOhh9OgO4hxjnbhrrEzecVGKivYJWPo0=; b=KV2Zd4cDtctASLstZ vOW9d6rDTLyRdnnqrcCoaUglaoD6sxIaORz8y+KOai3VIHeRI2XFlK7u01x6VGSx shCo8rcqmTVN384Da94bqZWsWtHFT6dqllKyAq+y6A3gppcgRrRRmSCudkyzq+6D Tqo7TXG5mfWNZ3rj62Ax4uy/RPrRt7XLDIuDvzTvTbS/zRB26dvUWy6KX0k1MGKB C5znrtubRF7cQm9ZxzHdHIfZq5zLZcd9+APf4HEa/7uN2kCz9Tu+4Ds5jC2RPXvw KXPuUjyTP4v94i8DUjXqFy118x3fiJjmjsUJ0FkRxNziUwUvJZGZQ8T4KJz9e8Zp j3DVA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40mewhrk46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jul 2024 20:00:50 +0000 (GMT) Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 46QK0o4N031982; Fri, 26 Jul 2024 20:00:50 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40mewhrk41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jul 2024 20:00:50 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 46QH1T4A009111; Fri, 26 Jul 2024 20:00:49 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 40gt93wsag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jul 2024 20:00:49 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 46QK0koP24904192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jul 2024 20:00:48 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AD8335806A; Fri, 26 Jul 2024 20:00:46 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C285058055; Fri, 26 Jul 2024 20:00:45 +0000 (GMT) Received: from [9.12.68.85] (unknown [9.12.68.85]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Fri, 26 Jul 2024 20:00:45 +0000 (GMT) Message-ID: <63ea00ec-ca05-4e52-b469-3c5b7d3da90a@linux.ibm.com> Date: Fri, 26 Jul 2024 16:00:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] target/s390x: filter deprecated properties based on model expansion type To: David Hildenbrand , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Cc: thuth@redhat.com, wangyanan55@huawei.com, philmd@linaro.org, marcel.apfelbaum@gmail.com, eduardo@habkost.net, armbru@redhat.com, Jiri Denemark References: <20240725183909.24144-1-walling@linux.ibm.com> <6f7b3367-4f13-44f0-8a04-f2be798e7bd3@redhat.com> Content-Language: en-US From: Collin Walling In-Reply-To: <6f7b3367-4f13-44f0-8a04-f2be798e7bd3@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vfWZIE11qG-tDTG0iz5AtTI_h5KkX2r_ X-Proofpoint-ORIG-GUID: wJ_hLA6uf37jhBg0wVbv6pF-b62XgtrA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-26_12,2024-07-26_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407260131 Received-SPF: pass client-ip=148.163.156.1; envelope-from=walling@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/26/24 3:57 PM, David Hildenbrand wrote: > On 25.07.24 20:39, Collin Walling wrote: >> Currently, there is no way to execute the query-cpu-model-expansion >> command to retrieve a comprehenisve list of deprecated properties, as >> the result is dependent per-model. To enable this, the expansion output >> is modified as such: >> >> When reporting a "static" CPU model, the command will only show >> deprecated properties that are a subset of the model's *enabled* >> properties. This is more accurate than how the query was handled >> before, which blindly reported properties that were never introduced >> for certain models. >> >> When reporting a "full" CPU model, show the *entire* list of deprecated >> properties regardless if they are supported on the model. A full >> expansion outputs all known CPU model properties anyway, so it makes >> sense to report all deprecated properties here too. This allows >> management apps to query a single model (e.g. host) to acquire the >> full list of deprecated properties. >> >> Additionally, the @deprecated-props array has been moved from the >> CpuModelInfo struct to the CpuModelExpansionInfo struct, since the data >> did not belong in the former. >> >> Acked-by: David Hildenbrand >> Suggested-by: Jiri Denemark >> Signed-off-by: Collin Walling >> --- >> > > Hmmm, this does not apply on current master ... maybe because Thomas > already merged part of it? > Uh oh, sorry about that. I'll fix this right now and post a v5 with a corrected rebase on master. -- Regards, Collin