* [PATCH] tests/qtest/libqos/e1000e: Use IVAR shift definitions
@ 2022-11-05 5:30 Akihiko Odaki
2022-11-05 16:53 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2022-11-05 5:30 UTC (permalink / raw)
Cc: qemu-devel, Thomas Huth, Laurent Vivier, Paolo Bonzini,
Yan Vugenfirer, Yuri Benditovich, Akihiko Odaki
There were still some constants defined in e1000_regs.h.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
tests/qtest/libqos/e1000e.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
index 178d61d04f..21683dd0fb 100644
--- a/tests/qtest/libqos/e1000e.c
+++ b/tests/qtest/libqos/e1000e.c
@@ -30,9 +30,9 @@
#include "e1000e.h"
#define E1000E_IVAR_TEST_CFG \
- (E1000E_RX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID | \
- ((E1000E_TX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << 8) | \
- ((E1000E_OTHER_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << 16) | \
+ (((E1000E_RX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_RXQ0_SHIFT) | \
+ ((E1000E_TX0_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_TXQ0_SHIFT) | \
+ ((E1000E_OTHER_MSG_ID | E1000_IVAR_INT_ALLOC_VALID) << E1000_IVAR_OTHER_SHIFT) | \
E1000_IVAR_TX_INT_EVERY_WB)
#define E1000E_RING_LEN (0x1000)
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qtest/libqos/e1000e: Use IVAR shift definitions
2022-11-05 5:30 [PATCH] tests/qtest/libqos/e1000e: Use IVAR shift definitions Akihiko Odaki
@ 2022-11-05 16:53 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-05 16:53 UTC (permalink / raw)
To: Akihiko Odaki
Cc: qemu-devel, Thomas Huth, Laurent Vivier, Paolo Bonzini,
Yan Vugenfirer, Yuri Benditovich
On 5/11/22 06:30, Akihiko Odaki wrote:
> There were still some constants defined in e1000_regs.h.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> tests/qtest/libqos/e1000e.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-05 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-05 5:30 [PATCH] tests/qtest/libqos/e1000e: Use IVAR shift definitions Akihiko Odaki
2022-11-05 16:53 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).