From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C6FCA9EAF for ; Mon, 21 Oct 2019 10:02:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3D9B20684 for ; Mon, 21 Oct 2019 10:02:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GmBNLUBa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3D9B20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUVu-0006As-PR for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 06:02:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39033) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUSe-0003wp-AN for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:58:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMUSa-0007aR-Dd for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:58:45 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:46101 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMUSZ-0007ZU-5X for qemu-devel@nongnu.org; Mon, 21 Oct 2019 05:58:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571651921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oIOAyND/cqIhkicgz2wGNT47kwnKIeHXS0PuLuEZ6oc=; b=GmBNLUBak9XmYDYjpxpdIaIQVhCjZ6Skm1CWdFT5lYbpICR7Vz8y3pUda597poOn4IrguQ TjDRPd3Cy2U5rQWrAKzr8njDK/tORP0DXAP96xUd0+4aIO6r8wg2oTxXWxAy9C756IZwjV Ft+fFLhB1g7PVbMoFGiZF5Gpl6FYZ4c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-FP4hv41pMyGfOW0AYAOB3A-1; Mon, 21 Oct 2019 05:58:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89A6E476; Mon, 21 Oct 2019 09:58:38 +0000 (UTC) Received: from [10.36.116.198] (ovpn-116-198.ams2.redhat.com [10.36.116.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id A65521001B09; Mon, 21 Oct 2019 09:58:36 +0000 (UTC) Subject: Re: [PATCH v1] s390x/kvm: Set default cpu model for all machine classes From: David Hildenbrand To: Thomas Huth , qemu-devel@nongnu.org References: <20191021093456.6168-1-david@redhat.com> <96381cf8-a6cf-9583-7eb2-92ad9d333c1b@redhat.com> Organization: Red Hat GmbH Message-ID: <6404748d-1711-b6d7-f13b-10250d74dc92@redhat.com> Date: Mon, 21 Oct 2019 11:58:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: FP4hv41pMyGfOW0AYAOB3A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Janosch Frank , Cornelia Huck , Richard Henderson , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Igor Mammedov , Jiri Denemark Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > query-machines probes with the "none" machine all other machines. > Current code only fixes up the active machine. >=20 To be more precise, libvirt probes with "-machine none,accel=3Dkvm:tcg"=20 all other machines. > (that's why you won't notice when starting a machine - you will always > get "host" for the active one) >=20 >> >> Anyway, your patch sounds fine, so (with "klass" replaced by "oc"): >> >> Reviewed-by: Thomas Huth >> >=20 >=20 --=20 Thanks, David / dhildenb