From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Rikalo" <arikalo@gmail.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Anton Johansson" <anjo@rev.ng>
Subject: Re: [PATCH 05/12] target/mips: Introduce mo_endian() helper
Date: Thu, 3 Oct 2024 15:56:47 -0700 [thread overview]
Message-ID: <6413cf66-c1e6-4754-a26b-2467999c699e@linaro.org> (raw)
In-Reply-To: <20240930091101.40591-6-philmd@linaro.org>
On 9/30/24 02:10, Philippe Mathieu-Daudé wrote:
> Introduce mo_endian() which returns the endian MemOp
> corresponding to the vCPU DisasContext.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/mips/tcg/translate.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/target/mips/tcg/translate.h b/target/mips/tcg/translate.h
> index 2b6646b339..54955437ef 100644
> --- a/target/mips/tcg/translate.h
> +++ b/target/mips/tcg/translate.h
> @@ -240,4 +240,9 @@ static inline bool cpu_is_bigendian(DisasContext *ctx)
> return extract32(ctx->CP0_Config0, CP0C0_BE, 1);
> }
>
> +static inline MemOp mo_endian(DisasContext *dc)
> +{
> + return cpu_is_bigendian(dc) ? MO_BE : MO_LE;
> +}
Based on patch 6, I think you'd better pass 'bool reversed' to this function.
Then
disas_is_bigendian(dc) ^ reversed ? MO_BE : MO_LE;
r~
next prev parent reply other threads:[~2024-10-03 22:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 9:10 [PATCH 00/12] target/mips: Remove target-specific endianness knowledge Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 01/12] target/mips: Declare cpu_is_bigendian_env() in 'internal.h' Philippe Mathieu-Daudé
2024-10-03 22:52 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 02/12] target/mips: Introduce mo_endian_env() helper Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 03/12] target/mips: Replace MO_TE by mo_endian_env() in get_pte() Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 04/12] target/mips: Convert mips16e decr_and_load/store() macros to functions Philippe Mathieu-Daudé
2024-10-03 22:55 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 05/12] target/mips: Introduce mo_endian() helper Philippe Mathieu-Daudé
2024-10-03 22:56 ` Richard Henderson [this message]
2024-09-30 9:10 ` [PATCH 06/12] target/mips: Explode MO_TExx -> MO_TE | MO_xx Philippe Mathieu-Daudé
2024-10-01 9:56 ` Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 07/12] target/mips: Replace MO_TE by mo_endian() Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 08/12] target/mips: Expose MIPSCPU::is_big_endian property Philippe Mathieu-Daudé
2024-10-03 22:59 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 09/12] hw/mips/cps: Set the vCPU 'cpu-big-endian' property Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 10/12] hw/mips: Have mips_cpu_create_with_clock() take an endianness argument Philippe Mathieu-Daudé
2024-09-30 9:11 ` [PATCH 11/12] target/mips: Remove target-specific code in mips_cpu_reset_hold() Philippe Mathieu-Daudé
2024-10-03 23:01 ` Richard Henderson
2024-10-10 20:22 ` Philippe Mathieu-Daudé
2024-09-30 9:11 ` [PATCH 12/12] hw/mips/malta: Remove TARGET_BIG_ENDIAN #ifdef'ry Philippe Mathieu-Daudé
2024-09-30 12:25 ` [PATCH 00/12] target/mips: Remove target-specific endianness knowledge Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6413cf66-c1e6-4754-a26b-2467999c699e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).