From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter
Date: Wed, 25 Apr 2018 14:47:27 +0200 [thread overview]
Message-ID: <6418edf4-e94c-02eb-0b6d-86fada5986fa@redhat.com> (raw)
In-Reply-To: <fae01c1a-1780-7bb6-2396-f21dd9b2c6b6@redhat.com>
>>> int ret;
>>> @@ -346,6 +355,14 @@ static void ccw_init(MachineState *machine)
>>> /* Create VirtIO network adapters */
>>> s390_create_virtio_net(BUS(css_bus), "virtio-net-ccw");
>>>
>>> + /* init consoles */
>>> + if (serial_hds[0]) {
>>> + s390_create_sclpconsole("sclpconsole", serial_hds[0]);
>>> + }
>>> + if (serial_hds[1]) {
>>> + s390_create_sclpconsole("sclplmconsole", serial_hds[1]);
>>> + }
>>
>> What happens if more -serial are defined? An error? Silently ignored?
>
> Silently ignored, since this is also what almost all other machines are
> doing (look for serial_hds in hw/ and you'll see what I mean).
>
>> (e.g. do we have to redefine MAX_SERIAL_PORTS on s390x or add checking
>> code here?)
>
> As all the other machines are also not redefining MAX_SERIAL_PORTS, I
> think we should also not do this on s390x now, should we?
Then I guess if we would introduce it, we should do it for all other
implementations. So I think we can just leave it as it is.
>
> Thomas
>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-04-25 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 5:21 [Qemu-devel] [PATCH v1] hw/s390x: Allow to configure the consoles with the "-serial" parameter Thomas Huth
2018-04-25 9:50 ` David Hildenbrand
2018-04-25 10:17 ` Thomas Huth
2018-04-25 12:31 ` Peter Maydell
2018-04-25 14:00 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-26 14:13 ` Peter Maydell
2018-04-25 12:47 ` David Hildenbrand [this message]
2018-04-25 12:15 ` [Qemu-devel] " Christian Borntraeger
2018-04-25 13:58 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6418edf4-e94c-02eb-0b6d-86fada5986fa@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).