Re: [PATCH 1/2] Fix for Haiku

[Thomas Huth <thuth@redhat.com>]

On 03/07/2021 23.10, Richard Zak wrote:
> For Haiku: turn off TPM, disable mips & xtensa emulators as they won't 
> compile on Haiku, use Haiku's capstone. I'm resending this as I previously 
> sent to the wrong address. This should resolve the memory issue with "make 
> vm-build-haiku.x86_64"
> 
> Signed-off-by: Richard Zak <richard.j.zak@gmail.com 
> <mailto:richard.j.zak@gmail.com>>
> ---
>   configure | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index e799d908a3..a965c6c72e 100755
> --- a/configure
> +++ b/configure
> @@ -358,6 +358,7 @@ oss_lib=""
>   bsd="no"
>   linux="no"
>   solaris="no"
> +haiku="no"
>   profiler="no"
>   cocoa="auto"
>   softmmu="yes"
> @@ -769,7 +770,10 @@ SunOS)
>   ;;
>   Haiku)
>     haiku="yes"
> -  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
> +  tpm="no"

Why is tpm support not auto-detected?

> +  capstone="system"
> +  target_list_exclude="mips-softmmu mipsel-softmmu mips64-softmmu 
> mips64el-softmmu xtensa-softmmu xtensaeb-softmmu"

I think it's rather a bad idea to set target_list_exclude here since this 
will prevent that the users can use their own "--target-list" and 
"--target-list-exclude" switches for the configure script. But maybe you 
could add some logic later that checks whether the user set a target list, 
and if that's not the case then tweak the target_list_exclude accordingly.

> +  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE -I`finddir 
> B_SYSTEM_HEADERS_DIRECTORY`/capstone $QEMU_CFLAGS"
>   ;;
>   Linux)
>     audio_drv_list="try-pa oss"
> -- 
> 2.25.1

  Thomas