From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69D0ACD11DF for ; Thu, 28 Mar 2024 17:56:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpty1-0004D6-DD; Thu, 28 Mar 2024 13:55:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rptxw-0004C2-3t for qemu-devel@nongnu.org; Thu, 28 Mar 2024 13:55:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rptxt-0000ZL-MT for qemu-devel@nongnu.org; Thu, 28 Mar 2024 13:55:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711648500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LET63Pf/YiDcqeIhd9/QgGNFknYJxlLAejj09HdApU4=; b=UZbK3nY+gqXRdyAw7/+MIlpWtwpPZf3kfY4UGNE580eP95mjR9x/JeCFM//KYjyr5kcq4i puA3t6wAmOQx3L6R9gBBHAQr01sGS7RIcoodU/i61wI3dW+7zT6PDY7RV+ysDbIVo4ZpSM MWoJQ7GExVGA2jigzqPFC6gzNr16Acc= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-gt12QNbtP6a98fisMijaZw-1; Thu, 28 Mar 2024 13:54:57 -0400 X-MC-Unique: gt12QNbtP6a98fisMijaZw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69695434a2aso12383676d6.3 for ; Thu, 28 Mar 2024 10:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711648497; x=1712253297; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LET63Pf/YiDcqeIhd9/QgGNFknYJxlLAejj09HdApU4=; b=XJt8bYSfFn13TO86V2JlFnO6zbhdr4Gt2j1Y5H9DVwaa/aFThnxAKiv1v4zNqEKDng GLOT/zRoaFBl5JAffV4b+9h5xnM77Hdar6uzA7kjSffmFtBFpb38PCMAQVPibn2Kqezs /G27V54pCaZHceYNOzHrQGx7gllGlDOehUggb0hul0dIotBG2Trxq7DNefsrK5vj6TNq VcNLwOlljZUx/qrdw4GBM43P7Ahc1BmddUTEJhmhE9pr/1iYVytYwO5zFeITBBoS/pKz kwjA6D52gcVLo/nPfA5VQtlrizNQ22flnU4GJVoR3VmSbBNuRZrZznFN7KDX0/5FfIh/ vx4A== X-Forwarded-Encrypted: i=1; AJvYcCVQtunUFCpMRLrzMM0euCIl0OWN2lIxHSq1ryrfdKQExfEa7kEn/UpDbEBPpPeA4cnR4dWnWmQEvOaWmvlbJOYz2rVbndQ= X-Gm-Message-State: AOJu0Yxa7AMUsAQcxyJcik7y+RkI+EhZl8Xkm+u6zMTAFJczcGfVgAl7 uLH3tez2y4vjzcbZHffglIij8iYRzFYFzethmyzRwPTDtYBvHDY4hViHqVHt6T/hvRmOYpdKi37 4U1GoL35LIYegjx4v401QWEkqbwnVT35hac4e0qVORHhsg80Lrgim X-Received: by 2002:a0c:e647:0:b0:696:8402:84d2 with SMTP id c7-20020a0ce647000000b00696840284d2mr3238589qvn.15.1711648497375; Thu, 28 Mar 2024 10:54:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfmrdUh2poLeMl0dbsOmVJAEX9rrac9cZg/KdE1wFuRILQCSGtXu+gk5g3K7Y5xnIknC+uaQ== X-Received: by 2002:a0c:e647:0:b0:696:8402:84d2 with SMTP id c7-20020a0ce647000000b00696840284d2mr3238567qvn.15.1711648497097; Thu, 28 Mar 2024 10:54:57 -0700 (PDT) Received: from [192.168.0.9] (ip-109-43-177-37.web.vodafone.de. [109.43.177.37]) by smtp.gmail.com with ESMTPSA id qq2-20020a0562142c0200b0069687cdaba3sm839401qvb.36.2024.03.28.10.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:54:56 -0700 (PDT) Message-ID: <641d176e-7990-4bb3-a39d-518c976cb059@redhat.com> Date: Thu, 28 Mar 2024 18:54:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-9.1 v2 3/3] block/gluster: Remove RDMA protocol handling To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Yuval Shaia , Kevin Wolf , Prasanna Kumar Kalever , Fabiano Rosas , Cornelia Huck , Michael Roth , Li Zhijian , Prasanna Kumar Kalever , Peter Xu , integration@gluster.org, Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , devel@lists.libvirt.org, Hanna Reitz , "Michael S. Tsirkin" , Eric Blake References: <20240328130255.52257-1-philmd@linaro.org> <20240328130255.52257-4-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240328130255.52257-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.08, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/03/2024 14.02, Philippe Mathieu-Daudé wrote: > GlusterFS+RDMA has been deprecated 8 years ago in commit > 0552ff2465 ("block/gluster: deprecate rdma support"): > > gluster volfile server fetch happens through unix and/or tcp, > it doesn't support volfile fetch over rdma. The rdma code may > actually mislead, so to make sure things do not break, for now > we fallback to tcp when requested for rdma, with a warning. > > If you are wondering how this worked all these days, its the > gluster libgfapi code which handles anything other than unix > transport as socket/tcp, sad but true. > > Besides, the whole RDMA subsystem was deprecated in commit > e9a54265f5 ("hw/rdma: Deprecate the pvrdma device and the rdma > subsystem") released in v8.2. > > Cc: Prasanna Kumar Kalever > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/device-url-syntax.rst.inc | 4 +-- > docs/system/qemu-block-drivers.rst.inc | 1 - > block/gluster.c | 39 -------------------------- > 3 files changed, 2 insertions(+), 42 deletions(-) Reviewed-by: Thomas Huth