From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhINa-0004qo-8D
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 11:33:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhINU-0006DK-J0
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 11:33:41 -0400
Received: from mx5-phx2.redhat.com ([209.132.183.37]:55393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1bhINU-0006Cr-At
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 11:33:36 -0400
Date: Tue, 6 Sep 2016 11:33:34 -0400 (EDT)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <644501471.140688.1473176014062.JavaMail.zimbra@redhat.com>
In-Reply-To: <CAFEAcA-=8s+Qr96wra3Uag=R3ddHU-bO_eLmy6+OH3XpH_ZoLg@mail.gmail.com>
References: <20160906122639.11163-1-marcandre.lureau@redhat.com>
	<CAFEAcA-=8s+Qr96wra3Uag=R3ddHU-bO_eLmy6+OH3XpH_ZoLg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 00/26] Leak patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Hi

----- Original Message -----
> On 6 September 2016 at 13:26, Marc-Andr=C3=A9 Lureau
> <marcandre.lureau@redhat.com> wrote:
> > The following changes since commit
> > 1fd66154fdf8305e6668a96046a22b863b4d7320:
> >
> >   Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160905' =
into
> >   staging (2016-09-06 11:43:18 +0100)
> >
> > are available in the git repository at:
> >
> >   git@github.com:elmarco/qemu.git tags/leak-pull-request
> >
> > for you to fetch changes up to 58d104a7f2698ffff3ee5976f96ebcff111be63b=
:
> >
> >   tests: fix postcopy-test leaks (2016-09-06 16:20:27 +0400)
> >
> > ----------------------------------------------------------------
>=20
> I'm afraid this doesn't build with our minimum glib version:
>=20
> /Users/pm215/src/qemu-for-merges/tests/libqtest.c:771:42: error: expected=
 ')'
>                       (GTestFixtureFunc) fn, (GTestFixtureFunc)
>                       data_free_func);
>                                          ^
> /Users/pm215/src/qemu-for-merges/tests/libqtest.c:770:22: note: to
> match this '('
>     g_test_add_vtable(path, 0, data, NULL,
>                      ^
> 1 error generated.
>=20
> The GTestFixtureFunc typedef was only introduced in glib 2.28, and our
> minimum is 2.22.

Argh,..

>=20
> Also, g_test_add_vtable() in glib 2.22 has this prototype:
>=20
> void    g_test_add_vtable               (const char     *testpath,
>                                          gsize           data_size,
>                                          gconstpointer   test_data,
>                                          void          (*data_setup)
>                                          (void),
>                                          void          (*data_test)
>                                          (void),
>                                          void          (*data_teardown)
>                                          (void));
>=20
> but GTestFixtureFunc is typedefed in newer glib as
> void (*GTestFixtureFunc) (gpointer fixture, gconstpointer user_data);
>=20
> so it looks like this function has changed signature somewhere
> between glib versions, which makes me a bit nervous about using it.

Perhaps we should get back to the simpler version, only using g_test_add_da=
ta_func_full() with 2.34:
https://patchwork.kernel.org/patch/9251373/

I can update the patch that way with a comment about expected leaks < 2.34.

there is no discussions about bumping the glib requirements btw?