From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK5Dg-0007Po-5Z for qemu-devel@nongnu.org; Fri, 26 Apr 2019 14:05:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hK5De-0000FO-4y for qemu-devel@nongnu.org; Fri, 26 Apr 2019 14:05:08 -0400 References: <20190415144948.78568-1-vsementsov@virtuozzo.com> <20190415144948.78568-4-vsementsov@virtuozzo.com> From: Max Reitz Message-ID: <6445f4e0-a547-2119-2a1a-db5e5cb8de26@redhat.com> Date: Fri, 26 Apr 2019 20:04:52 +0200 MIME-Version: 1.0 In-Reply-To: <20190415144948.78568-4-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a" Subject: Re: [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, den@openvz.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, den@openvz.org Message-ID: <6445f4e0-a547-2119-2a1a-db5e5cb8de26@redhat.com> Subject: Re: [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping References: <20190415144948.78568-1-vsementsov@virtuozzo.com> <20190415144948.78568-4-vsementsov@virtuozzo.com> In-Reply-To: <20190415144948.78568-4-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote: > Split allocation checking to separate function and reduce nesting. > Consider bdrv_is_allocated() fail as allocated area, as copying more > than needed is not wrong (and we do it anyway) and seems better than > fail the whole job. And, most probably we will fail on the next read, > if there are real problem with source. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 60 +++++++++++++++++++-------------------------------= > 1 file changed, 23 insertions(+), 37 deletions(-) Reviewed-by: Max Reitz --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzDSEQACgkQ9AfbAGHV z0B6Ugf9H6dQBk8pOO9GveBUJtNnWWLcSd90zoGWv132fYUrxURNTEBWKtg1kVCb J738Q6Po3iT0ZXBvB5yd6Jv42dRycju04SEfIDixENbYrlH8ny6NtsBGFgORqgjV ZChX0ecSPY0MCHEAclKh5lk3otF7Nn4KfhBCaQ+MPZ2K4oHYKTzixAPhrYeaCWSY cYf2L7R1jADXOyUNdFVZ4YWy/lKZMvgNk9kH8QIlcv2XXZW08yxjqP6Xdi22HaFB PlOxW/23xT+jWUM3+YoGS5DZZUWFs7urBPbfCngWq2nomdfCpp8mlhK6Z7wfXM7g t8G1iwyxIg2P5bjKcK9OB5G4i1tZ9w== =SCwb -----END PGP SIGNATURE----- --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF533C43219 for ; Fri, 26 Apr 2019 18:06:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5FB520679 for ; Fri, 26 Apr 2019 18:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5FB520679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:50402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK5EZ-0007ss-Jk for qemu-devel@archiver.kernel.org; Fri, 26 Apr 2019 14:06:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hK5Dg-0007Po-5Z for qemu-devel@nongnu.org; Fri, 26 Apr 2019 14:05:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hK5De-0000FO-4y for qemu-devel@nongnu.org; Fri, 26 Apr 2019 14:05:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55218) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hK5DY-00005m-EZ; Fri, 26 Apr 2019 14:05:02 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 693403D47D; Fri, 26 Apr 2019 18:04:58 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-204-82.brq.redhat.com [10.40.204.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B58E60E3D; Fri, 26 Apr 2019 18:04:54 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20190415144948.78568-1-vsementsov@virtuozzo.com> <20190415144948.78568-4-vsementsov@virtuozzo.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <6445f4e0-a547-2119-2a1a-db5e5cb8de26@redhat.com> Date: Fri, 26 Apr 2019 20:04:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190415144948.78568-4-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 26 Apr 2019 18:04:58 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190426180452.5j-J7DehL4m_0-0_i1GEHweYnVS3U_EscKNa9Uen53U@z> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, den@openvz.org Message-ID: <6445f4e0-a547-2119-2a1a-db5e5cb8de26@redhat.com> Subject: Re: [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping References: <20190415144948.78568-1-vsementsov@virtuozzo.com> <20190415144948.78568-4-vsementsov@virtuozzo.com> In-Reply-To: <20190415144948.78568-4-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote: > Split allocation checking to separate function and reduce nesting. > Consider bdrv_is_allocated() fail as allocated area, as copying more > than needed is not wrong (and we do it anyway) and seems better than > fail the whole job. And, most probably we will fail on the next read, > if there are real problem with source. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 60 +++++++++++++++++++-------------------------------= > 1 file changed, 23 insertions(+), 37 deletions(-) Reviewed-by: Max Reitz --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzDSEQACgkQ9AfbAGHV z0B6Ugf9H6dQBk8pOO9GveBUJtNnWWLcSd90zoGWv132fYUrxURNTEBWKtg1kVCb J738Q6Po3iT0ZXBvB5yd6Jv42dRycju04SEfIDixENbYrlH8ny6NtsBGFgORqgjV ZChX0ecSPY0MCHEAclKh5lk3otF7Nn4KfhBCaQ+MPZ2K4oHYKTzixAPhrYeaCWSY cYf2L7R1jADXOyUNdFVZ4YWy/lKZMvgNk9kH8QIlcv2XXZW08yxjqP6Xdi22HaFB PlOxW/23xT+jWUM3+YoGS5DZZUWFs7urBPbfCngWq2nomdfCpp8mlhK6Z7wfXM7g t8G1iwyxIg2P5bjKcK9OB5G4i1tZ9w== =SCwb -----END PGP SIGNATURE----- --6jpEkXVsm50U3d0pWYJiuhpdIEyHdq95a--