From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com, jsnow@redhat.com, kraxel@redhat.com,
mreitz@redhat.com
Subject: Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
Date: Thu, 30 Jul 2020 09:56:06 -0500 [thread overview]
Message-ID: <644d4bc4-72ac-f657-7396-d3d72e96ec67@redhat.com> (raw)
In-Reply-To: <20200730091656.2633334-1-armbru@redhat.com>
On 7/30/20 4:16 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 24 ++++++++++++------------
> qapi/ui.json | 4 ++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> +++ b/qapi/ui.json
> @@ -1081,8 +1081,8 @@
> # Since: 3.0
> #
> ##
> - { 'enum' : 'DisplayGLMode',
> - 'data' : [ 'off', 'on', 'core', 'es' ] }
> +{ 'enum' : 'DisplayGLMode',
> + 'data' : [ 'off', 'on', 'core', 'es' ] }
We are really inconsistent on whether we use space before ':'. Oh well,
not the problem of this patch.
With the one additional line reindented as covered by Max' review,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-30 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
2020-07-30 13:11 ` Max Reitz
2020-07-30 14:50 ` Markus Armbruster
2020-07-30 14:56 ` Eric Blake [this message]
2020-08-03 6:24 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644d4bc4-72ac-f657-7396-d3d72e96ec67@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).