From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E775C433DF for ; Thu, 30 Jul 2020 14:56:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A98C2070B for ; Thu, 30 Jul 2020 14:56:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YQltNmvq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A98C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k19zO-0005Kr-Ii for qemu-devel@archiver.kernel.org; Thu, 30 Jul 2020 10:56:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k19yh-0004tL-P2 for qemu-devel@nongnu.org; Thu, 30 Jul 2020 10:56:15 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:48813 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k19yg-0002Tl-6L for qemu-devel@nongnu.org; Thu, 30 Jul 2020 10:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596120973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dSsb78aZL32Uhm8uJTMMiiTG+mjtf0CxLUhTdV4KWA8=; b=YQltNmvqjJ5sBXKsy4laaSpY6YdqJZB8ydg0s0VDIvGq533Ulzcl/0pe1DX6v2epD4kFXs yudShRGN29tIiJEt7Wwwij8/pMT8C2oTK0cuKQEIjoQ0XeZVlfC0jxFBz03FxKftXapszR FZ90qfg/7VIoQqE/DkGPuelsd8sC4dE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-fEVfsEamO8mUEw9V-MBCCw-1; Thu, 30 Jul 2020 10:56:11 -0400 X-MC-Unique: fEVfsEamO8mUEw9V-MBCCw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FCCB10059BF; Thu, 30 Jul 2020 14:56:10 +0000 (UTC) Received: from [10.3.114.255] (ovpn-114-255.phx2.redhat.com [10.3.114.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97DCF619B5; Thu, 30 Jul 2020 14:56:06 +0000 (UTC) Subject: Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions To: Markus Armbruster , qemu-devel@nongnu.org References: <20200730091656.2633334-1-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <644d4bc4-72ac-f657-7396-d3d72e96ec67@redhat.com> Date: Thu, 30 Jul 2020 09:56:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200730091656.2633334-1-armbru@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 03:59:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, jsnow@redhat.com, kraxel@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/30/20 4:16 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 24 ++++++++++++------------ > qapi/ui.json | 4 ++-- > 2 files changed, 14 insertions(+), 14 deletions(-) > > +++ b/qapi/ui.json > @@ -1081,8 +1081,8 @@ > # Since: 3.0 > # > ## > - { 'enum' : 'DisplayGLMode', > - 'data' : [ 'off', 'on', 'core', 'es' ] } > +{ 'enum' : 'DisplayGLMode', > + 'data' : [ 'off', 'on', 'core', 'es' ] } We are really inconsistent on whether we use space before ':'. Oh well, not the problem of this patch. With the one additional line reindented as covered by Max' review, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org