From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
Greg Kurz <groug@kaod.org>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 11/11] tests/9pfs: add local Tmkdir test
Date: Fri, 02 Oct 2020 16:30:17 +0200 [thread overview]
Message-ID: <6486076.Ap9L6znzn6@silver> (raw)
In-Reply-To: <20201002142331.GF2338114@redhat.com>
On Freitag, 2. Oktober 2020 16:23:31 CEST Daniel P. Berrangé wrote:
> No need to realloate a new array - just shuffle down the elements in
> the array you get back from g_strsplit to discard the empty ones. Sure
> the array will end up with a series of NULLs at the end but that is
> harmless.
>
> both g_strsplit/g_strfreev work in terms of a normal allocated "char **"
> array, so there's no risk of changes to way memory is allocated.
Ok then, if you say so ... fine with me.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-10-02 14:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:52 [PATCH v2 00/11] 9pfs: add tests using local fs driver Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 09/11] tests/9pfs: wipe local 9pfs test directory Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 01/11] libqos/qgraph: add qemu_name to QOSGraphNode Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 04/11] tests/qtest/qos-test: dump qos graph if verbose Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 03/11] libqos/qgraph: add qos_dump_graph() Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 11/11] tests/9pfs: add local Tmkdir test Christian Schoenebeck
2020-10-02 12:56 ` Daniel P. Berrangé
2020-10-02 13:41 ` Christian Schoenebeck
2020-10-02 13:44 ` Daniel P. Berrangé
2020-10-02 14:09 ` Christian Schoenebeck
2020-10-02 14:23 ` Daniel P. Berrangé
2020-10-02 14:30 ` Christian Schoenebeck [this message]
2020-10-02 14:32 ` Greg Kurz
2020-10-02 15:00 ` Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 05/11] tests/qtest/qos-test: dump environment variables if verbose Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 02/11] libqos/qgraph: add qos_node_create_driver_named() Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 10/11] tests/9pfs: add virtio_9p_test_path() Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 08/11] tests/9pfs: introduce local tests Christian Schoenebeck
2020-10-02 14:26 ` Christian Schoenebeck
2020-10-02 14:35 ` Daniel P. Berrangé
2020-10-02 11:51 ` [PATCH v2 06/11] tests/qtest/qos-test: dump QEMU command if verbose Christian Schoenebeck
2020-10-02 11:51 ` [PATCH v2 07/11] tests/9pfs: change qtest name prefix to synth Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6486076.Ap9L6znzn6@silver \
--to=qemu_oss@crudebyte.com \
--cc=berrange@redhat.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).